Set up new desktop classes.

Set up new desktop classes.

http://crbug.com/146077
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154967

[sky, 2012-08-31 22:58:59]

http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_na...
File ui/views/widget/desktop_native_widget_aura.h (right):

http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_na...
ui/views/widget/desktop_native_widget_aura.h:139:
internal::NativeWidgetDelegate* native_widget_delegate_;
You never set this.

http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_ro...
File ui/views/widget/desktop_root_window_host_win.cc (right):

http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_ro...
ui/views/widget/desktop_root_window_host_win.cc:17: message_handler_(NULL) {
nit: neither of these are needed since they're scoped_ptrs.

[Ben Goodger (Google), 2012-08-31 23:14:53]

yeah i was going to init all these in a future pass. this was just to get
it to build.


On Fri, Aug 31, 2012 at 3:58 PM, <sky@chromium.org> wrote:

>
> http://codereview.chromium.**org/10908048/diff/10002/ui/**
>
views/widget/desktop_native_**widget_aura.h<http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_native_widget_aura.h>
> File ui/views/widget/desktop_**native_widget_aura.h (right):
>
> http://codereview.chromium.**org/10908048/diff/10002/ui/**
>
views/widget/desktop_native_**widget_aura.h#newcode139<http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_native_widget_aura.h#newcode139>
> ui/views/widget/desktop_**native_widget_aura.h:139:
> internal::**NativeWidgetDelegate* native_widget_delegate_;
> You never set this.
>
> http://codereview.chromium.**org/10908048/diff/10002/ui/**
>
views/widget/desktop_root_**window_host_win.cc<http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_root_window_host_win.cc>
> File ui/views/widget/desktop_root_**window_host_win.cc (right):
>
> http://codereview.chromium.**org/10908048/diff/10002/ui/**
>
views/widget/desktop_root_**window_host_win.cc#newcode17<http://codereview.chromium.org/10908048/diff/10002/ui/views/widget/desktop_root_window_host_win.cc#newcode17>
> ui/views/widget/desktop_root_**window_host_win.cc:17:
> message_handler_(NULL) {
> nit: neither of these are needed since they're scoped_ptrs.
>
>
http://codereview.chromium.**org/10908048/<http://codereview.chromium.org/109...
>

[sky, 2012-08-31 23:46:19]

LGTM

[commit-bot: I haz the power, 2012-09-01 02:04:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ben@chromium.org/10908048/10002

[commit-bot: I haz the power, 2012-09-01 02:31:16]

Try job failure for 10908048-10002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...