Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 10908044: Refuse invalid SearchProvider and OSDD suggest URLs; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 171a20835b1dafdd73af64940dcecc2ca11fce6e..4f9e9fb300c5736c2930728d08298a039c59916a 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -239,12 +239,11 @@ class SearchProvider : public AutocompleteProvider,
void ApplyCalculatedNavigationRelevance(NavigationResults* list,
bool is_keyword);
- // Creates a URLFetcher requesting suggest results from the specified
- // |suggestions_url|. The caller owns the returned URLFetcher.
- net::URLFetcher* CreateSuggestFetcher(
- int id,
- const TemplateURLRef& suggestions_url,
- const string16& text);
+ // Starts a new URLFetcher requesting suggest results from |template_url|;
+ // callers own the returned URLFetcher, which is NULL for invalid providers.
+ net::URLFetcher* CreateSuggestFetcher(int id,
+ const TemplateURL* template_url,
+ const string16& text);
// Parses results from the suggest server and updates the appropriate suggest
// and navigation result lists, depending on whether |is_keyword| is true.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/search_engines/template_url_parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698