Issue 10908031: Treats ASCII numbers as word characters only on LTR languages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908031: Treats ASCII numbers as word characters only on LTR languages. (Closed)

Created:
8 years, 3 months ago by Hironori Bono

Modified:
8 years, 3 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Treats ASCII numbers as word characters only on LTR languages. This change is a follow-up change of my r145277 <http://crrev.com/145277>;. Even though this change always treats ASCII numbers as word characters, it is not an expected behavior on RTL languages. This change prevents treating ASCII numbers as word characters on RTL languages (Arabic and Hebrew). BUG=145028 TEST=SpellCheckWordIteratorTest.TreatNumbersAsWordCharacters Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154731

Patch Set 1 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -1 line)			Patch
	M	chrome/renderer/spellchecker/spellcheck_worditerator.cc	View		3 chunks	+8 lines, -1 line	0 comments	Download
	M	chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 3 months ago (2012-09-03 03:57:04 UTC) #3

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages