Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/google/google_util_unittest.cc

Issue 10908028: Allow the X-Chrome-Variations header to transmit to all ports. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix up some tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/utf_string_conversions.h" 5 #include "base/utf_string_conversions.h"
6 #include "chrome/browser/google/google_url_tracker.h" 6 #include "chrome/browser/google/google_url_tracker.h"
7 #include "chrome/browser/google/google_util.h" 7 #include "chrome/browser/google/google_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 using google_util::IsGoogleDomainUrl; 10 using google_util::IsGoogleDomainUrl;
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 "http://www.google.com/search?q=something&vespv=1")); 270 "http://www.google.com/search?q=something&vespv=1"));
271 EXPECT_FALSE(IsInstantExtendedAPIGoogleSearchUrl( 271 EXPECT_FALSE(IsInstantExtendedAPIGoogleSearchUrl(
272 "http://www.google.com/search?q=something&espvx=1")); 272 "http://www.google.com/search?q=something&espvx=1"));
273 EXPECT_FALSE(IsInstantExtendedAPIGoogleSearchUrl( 273 EXPECT_FALSE(IsInstantExtendedAPIGoogleSearchUrl(
274 "http://www.google.com/search#q=something&espv=1")); 274 "http://www.google.com/search#q=something&espv=1"));
275 } 275 }
276 276
277 TEST(GoogleUtilTest, GoogleDomains) { 277 TEST(GoogleUtilTest, GoogleDomains) {
278 // Test some good Google domains (valid TLDs). 278 // Test some good Google domains (valid TLDs).
279 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com", 279 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com",
280 google_util::ALLOW_SUBDOMAIN)); 280 google_util::ALLOW_SUBDOMAIN,
281 google_util::ALLOW_STANDARD_PORTS));
281 EXPECT_TRUE(IsGoogleDomainUrl("http://google.com", 282 EXPECT_TRUE(IsGoogleDomainUrl("http://google.com",
282 google_util::ALLOW_SUBDOMAIN)); 283 google_util::ALLOW_SUBDOMAIN,
284 google_util::ALLOW_STANDARD_PORTS));
283 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.ca", 285 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.ca",
284 google_util::ALLOW_SUBDOMAIN)); 286 google_util::ALLOW_SUBDOMAIN,
287 google_util::ALLOW_STANDARD_PORTS));
285 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.biz.tj", 288 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.biz.tj",
286 google_util::ALLOW_SUBDOMAIN)); 289 google_util::ALLOW_SUBDOMAIN,
290 google_util::ALLOW_STANDARD_PORTS));
287 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com/search?q=something", 291 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com/search?q=something",
288 google_util::ALLOW_SUBDOMAIN)); 292 google_util::ALLOW_SUBDOMAIN,
293 google_util::ALLOW_STANDARD_PORTS));
289 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com/webhp", 294 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com/webhp",
290 google_util::ALLOW_SUBDOMAIN)); 295 google_util::ALLOW_SUBDOMAIN,
296 google_util::ALLOW_STANDARD_PORTS));
291 297
292 // Test some bad Google domains (invalid TLDs). 298 // Test some bad Google domains (invalid TLDs).
293 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.notrealtld", 299 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.notrealtld",
294 google_util::ALLOW_SUBDOMAIN)); 300 google_util::ALLOW_SUBDOMAIN,
301 google_util::ALLOW_STANDARD_PORTS));
295 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.faketld/search?q=something", 302 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.faketld/search?q=something",
296 google_util::ALLOW_SUBDOMAIN)); 303 google_util::ALLOW_SUBDOMAIN,
304 google_util::ALLOW_STANDARD_PORTS));
297 EXPECT_FALSE(IsGoogleDomainUrl("http://www.yahoo.com", 305 EXPECT_FALSE(IsGoogleDomainUrl("http://www.yahoo.com",
298 google_util::ALLOW_SUBDOMAIN)); 306 google_util::ALLOW_SUBDOMAIN,
307 google_util::ALLOW_STANDARD_PORTS));
299 308
300 // Test subdomain checks. 309 // Test subdomain checks.
301 EXPECT_TRUE(IsGoogleDomainUrl("http://images.google.com", 310 EXPECT_TRUE(IsGoogleDomainUrl("http://images.google.com",
302 google_util::ALLOW_SUBDOMAIN)); 311 google_util::ALLOW_SUBDOMAIN,
312 google_util::ALLOW_STANDARD_PORTS));
303 EXPECT_FALSE(IsGoogleDomainUrl("http://images.google.com", 313 EXPECT_FALSE(IsGoogleDomainUrl("http://images.google.com",
304 google_util::DISALLOW_SUBDOMAIN)); 314 google_util::DISALLOW_SUBDOMAIN,
315 google_util::ALLOW_STANDARD_PORTS));
305 EXPECT_TRUE(IsGoogleDomainUrl("http://google.com", 316 EXPECT_TRUE(IsGoogleDomainUrl("http://google.com",
306 google_util::DISALLOW_SUBDOMAIN)); 317 google_util::DISALLOW_SUBDOMAIN,
318 google_util::ALLOW_STANDARD_PORTS));
307 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com", 319 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com",
308 google_util::DISALLOW_SUBDOMAIN)); 320 google_util::DISALLOW_SUBDOMAIN,
321 google_util::ALLOW_STANDARD_PORTS));
309 322
310 // Port and scheme checks. 323 // Port and scheme checks.
311 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com:80", 324 EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com:80",
312 google_util::DISALLOW_SUBDOMAIN)); 325 google_util::DISALLOW_SUBDOMAIN,
326 google_util::ALLOW_STANDARD_PORTS));
313 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.com:123", 327 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.com:123",
314 google_util::DISALLOW_SUBDOMAIN)); 328 google_util::DISALLOW_SUBDOMAIN,
329 google_util::ALLOW_STANDARD_PORTS));
315 EXPECT_TRUE(IsGoogleDomainUrl("https://www.google.com:443", 330 EXPECT_TRUE(IsGoogleDomainUrl("https://www.google.com:443",
316 google_util::DISALLOW_SUBDOMAIN)); 331 google_util::DISALLOW_SUBDOMAIN,
317 EXPECT_FALSE(IsGoogleDomainUrl("https://www.google.com:123", 332 google_util::ALLOW_STANDARD_PORTS));
318 google_util::DISALLOW_SUBDOMAIN)); 333 EXPECT_FALSE(IsGoogleDomainUrl("http://www.google.com:123",
334 google_util::DISALLOW_SUBDOMAIN,
335 google_util::ALLOW_STANDARD_PORTS));
336 EXPECT_TRUE(IsGoogleDomainUrl("https://www.google.com:123",
337 google_util::DISALLOW_SUBDOMAIN,
338 google_util::ALLOW_ALL_PORTS));
339 EXPECT_TRUE(IsGoogleDomainUrl("https://www.google.com:123",
340 google_util::DISALLOW_SUBDOMAIN,
341 google_util::ALLOW_ALL_PORTS));
319 EXPECT_FALSE(IsGoogleDomainUrl("file://www.google.com", 342 EXPECT_FALSE(IsGoogleDomainUrl("file://www.google.com",
320 google_util::DISALLOW_SUBDOMAIN)); 343 google_util::DISALLOW_SUBDOMAIN,
344 google_util::ALLOW_STANDARD_PORTS));
321 EXPECT_FALSE(IsGoogleDomainUrl("doesnotexist://www.google.com", 345 EXPECT_FALSE(IsGoogleDomainUrl("doesnotexist://www.google.com",
322 google_util::DISALLOW_SUBDOMAIN)); 346 google_util::DISALLOW_SUBDOMAIN,
347 google_util::ALLOW_STANDARD_PORTS));
323 } 348 }
324 349
325 TEST(GoogleUtilTest, SearchTerms) { 350 TEST(GoogleUtilTest, SearchTerms) {
326 // Simple searches. 351 // Simple searches.
327 EXPECT_EQ(string16(), google_util::GetSearchTermsFromGoogleSearchURL( 352 EXPECT_EQ(string16(), google_util::GetSearchTermsFromGoogleSearchURL(
328 "http://google.com/search?q=tractor+supply")); 353 "http://google.com/search?q=tractor+supply"));
329 EXPECT_EQ(ASCIIToUTF16("tractor supply"), 354 EXPECT_EQ(ASCIIToUTF16("tractor supply"),
330 google_util::GetSearchTermsFromGoogleSearchURL( 355 google_util::GetSearchTermsFromGoogleSearchURL(
331 "http://google.com/search?q=tractor+supply&espv=1")); 356 "http://google.com/search?q=tractor+supply&espv=1"));
332 // espv=1 only applies in query. 357 // espv=1 only applies in query.
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 389
365 // Blank terms in ref override non-blank terms in query. 390 // Blank terms in ref override non-blank terms in query.
366 EXPECT_EQ(string16(), google_util::GetSearchTermsFromGoogleSearchURL( 391 EXPECT_EQ(string16(), google_util::GetSearchTermsFromGoogleSearchURL(
367 "http://google.com/search?q=potato&espv=1#q=")); 392 "http://google.com/search?q=potato&espv=1#q="));
368 393
369 // Blank terms in query do not override non-blank terms in ref. 394 // Blank terms in query do not override non-blank terms in ref.
370 EXPECT_EQ(ASCIIToUTF16("tractor supply"), 395 EXPECT_EQ(ASCIIToUTF16("tractor supply"),
371 google_util::GetSearchTermsFromGoogleSearchURL( 396 google_util::GetSearchTermsFromGoogleSearchURL(
372 "http://google.com/search?q=&espv=1#q=tractor+supply")); 397 "http://google.com/search?q=&espv=1#q=tractor+supply"));
373 } 398 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698