Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 10908022: Valgrind: Fix some leaks in the CUPS printing code and remove a no longer supported OS X 10.5 check. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
Reviewers:
gene, gene1
CC:
chromium-reviews
Visibility:
Public.

Description

Valgrind: Fix some leaks in the CUPS printing code and remove a no longer supported OS X 10.5 check. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155483

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M printing/backend/print_backend_cups.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
8 years, 3 months ago (2012-08-30 20:23:07 UTC) #1
Lei Zhang
I'll wait for your CUPS CL to land and then see if this is still ...
8 years, 3 months ago (2012-09-05 22:18:24 UTC) #2
gene1
sounds good On Wed, Sep 5, 2012 at 3:18 PM, <thestig@chromium.org> wrote: > I'll wait ...
8 years, 3 months ago (2012-09-05 22:58:07 UTC) #3
Lei Zhang
PTAL
8 years, 3 months ago (2012-09-07 18:26:14 UTC) #4
gene
lgtm
8 years, 3 months ago (2012-09-07 18:36:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10908022/6001
8 years, 3 months ago (2012-09-07 18:47:16 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 21:21:29 UTC) #7
Change committed as 155483

Powered by Google App Engine
This is Rietveld 408576698