[Android] Refactor AndroidWebViewTestBase.

[Android] Refactor AndroidWebViewTestBase.

 - Move getTitleOnUiThread into AndroidWebViewTestBase;

 - add incognito mode flag to createAwTestContainerViewOnMainSync;

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154433

[joth, 2012-08-30 20:51:46]

LGTM

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
(right):

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java:153:
final boolean incognito,
fancy adding this one as an overload? I think 95% of tests will not care about
this param, and it keeps the callers cleaner not to have this extra thing to
think about. (I like the constants you added, but even then I have to think
'normal view, as opposed to what?' whereas most tests are just fine without it
at all)

[mkosiba (inactive), 2012-08-31 09:04:55]

LGTM

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
(right):

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java:153:
final boolean incognito,
On 2012/08/30 20:51:46, joth wrote:
> fancy adding this one as an overload? I think 95% of tests will not care about
> this param, and it keeps the callers cleaner not to have this extra thing to
> think about. (I like the constants you added, but even then I have to think
> 'normal view, as opposed to what?' whereas most tests are just fine without it
> at all)

Agree with Joth, if you add this as an override then the client code looks
clearer IMHO:

createAwTestContainerViewOnMainSync(client) for 'default' behavior, and
createAwTestContainerViewOnMainSync(INCOGNITO_VIEW, client) for incognito.

[mnaganov (inactive), 2012-08-31 12:17:03]

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
(right):

https://chromiumcodereview.appspot.com/10908014/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java:153:
final boolean incognito,
On 2012/08/31 09:04:56, Martin Kosiba wrote:
> On 2012/08/30 20:51:46, joth wrote:
> > fancy adding this one as an overload? I think 95% of tests will not care
about
> > this param, and it keeps the callers cleaner not to have this extra thing to
> > think about. (I like the constants you added, but even then I have to think
> > 'normal view, as opposed to what?' whereas most tests are just fine without
it
> > at all)
> 
> Agree with Joth, if you add this as an override then the client code looks
> clearer IMHO:
> 
> createAwTestContainerViewOnMainSync(client) for 'default' behavior, and
> createAwTestContainerViewOnMainSync(INCOGNITO_VIEW, client) for incognito.

Sounds reasonable. Added an overload.

[commit-bot: I haz the power, 2012-08-31 12:24:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/10908014/6001