Issue 10907232: Make browser_context.cc compile for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907232: Make browser_context.cc compile for iOS (Closed)

Created:
8 years, 3 months ago by stuartmorgan

Modified:
8 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make browser_context.cc compile for iOS iOS needs a BrowserContext destructor, since Profile inherits from BrowserContext, but none of the static functions are necessary. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157333

Patch Set 1 #

Patch Set 2 : Move char constants for cleaner ifdef-ing #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	content/browser/browser_context.cc	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download
	M	content/content_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

#ifdefs out all but the destructor, per our discussion.

8 years, 3 months ago (2012-09-14 09:52:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10907232/1003

8 years, 3 months ago (2012-09-18 04:56:02 UTC) #3

Change committed as 157333

Expand Messages | Collapse Messages