Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 10907225: Add API keys to SafeBrowsing client-side phishing and download verdict requests. (Closed)

Created:
8 years, 3 months ago by Brian Ryner
Modified:
8 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews
Visibility:
Public.

Description

Add API keys to SafeBrowsing client-side phishing and download verdict requests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M chrome/browser/safe_browsing/client_side_detection_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Brian Ryner
8 years, 3 months ago (2012-09-14 00:15:05 UTC) #1
mattm
On 2012/09/14 00:15:05, Brian Ryner wrote: Can you try both of these CLs locally with ...
8 years, 3 months ago (2012-09-14 03:21:52 UTC) #2
Brian Ryner
Good call. This one is fine, but http://codereview.chromium.org/10914274/ fails. It needs a small tweak to ...
8 years, 3 months ago (2012-09-14 03:52:58 UTC) #3
mattm
lgtm
8 years, 3 months ago (2012-09-14 04:17:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/10907225/1
8 years, 3 months ago (2012-09-14 04:22:56 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 3 months ago (2012-09-14 06:12:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/10907225/1
8 years, 3 months ago (2012-09-14 06:31:09 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 06:31:21 UTC) #8
Change committed as 156755

Powered by Google App Engine
This is Rietveld 408576698