Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 10907212: mac: Switch browser action backgrounds from vectors to bitmaps (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

mac: Switch browser action backgrounds from vectors to bitmaps Based on a patch from Andrew Bonventre <andybons@chromium.org>; BUG=111101 TEST=hover a browser action. highlight looks like the highlight on the reload button. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 4 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 3 months ago (2012-09-13 09:19:26 UTC) #1
Robert Sesek
lgtm
8 years, 3 months ago (2012-09-13 13:13:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10907212/1
8 years, 3 months ago (2012-09-13 13:23:57 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 13:24:09 UTC) #4
Change committed as 156539

Powered by Google App Engine
This is Rietveld 408576698