Issue 10907198: Do not load content_resources.pak on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907198: Do not load content_resources.pak on iOS. (Closed)

Created:
8 years, 3 months ago by msarda

Modified:
8 years, 3 months ago

Reviewers:
stuartmorgan, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Do not load content_resources.pak on iOS. content_resources.pak is not built on iOS as it is not required. Do not load it for tests to avoid confusion. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156779

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address code review: Fix nits. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	content/test/test_content_client.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM with nit. +jam https://chromiumcodereview.appspot.com/10907198/diff/1/content/test/test_content_client.cc File content/test/test_content_client.cc (right): https://chromiumcodereview.appspot.com/10907198/diff/1/content/test/test_content_client.cc#newcode16 content/test/test_content_client.cc:16: // loading it for tests ...

8 years, 3 months ago (2012-09-13 14:40:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/10907198/5001

8 years, 3 months ago (2012-09-14 08:21:17 UTC) #4

Change committed as 156779

Expand Messages | Collapse Messages