Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 10907196: Add the ability to filter out extension IMEs from the language settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index 54d3d43cf3893abe12b96d7a32f1e27c11fcde52..9cc7e2c6319d27445989eccbccdf798ccc9b5260 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -153,6 +153,9 @@ void Preferences::RegisterUserPrefs(PrefService* prefs) {
prefs->RegisterStringPref(prefs::kLanguagePreloadEngines,
hardware_keyboard_id,
PrefService::UNSYNCABLE_PREF);
+ prefs->RegisterStringPref(prefs::kLanguageFilteredExtensionImes,
+ "",
+ PrefService::UNSYNCABLE_PREF);
for (size_t i = 0; i < language_prefs::kNumChewingBooleanPrefs; ++i) {
prefs->RegisterBooleanPref(
language_prefs::kChewingBooleanPrefs[i].pref_name,
@@ -303,6 +306,8 @@ void Preferences::InitUserPrefs(PrefService* prefs) {
preferred_languages_.Init(prefs::kLanguagePreferredLanguages,
prefs, this);
preload_engines_.Init(prefs::kLanguagePreloadEngines, prefs, this);
+ filtered_extension_imes_.Init(prefs::kLanguageFilteredExtensionImes,
+ prefs, this);
current_input_method_.Init(prefs::kLanguageCurrentInputMethod, prefs, this);
previous_input_method_.Init(prefs::kLanguagePreviousInputMethod, prefs, this);
@@ -465,6 +470,16 @@ void Preferences::NotifyPrefChanged(const std::string* pref_name) {
preload_engines_.GetValue());
}
+ if (!pref_name || *pref_name == prefs::kLanguageFilteredExtensionImes) {
+ std::string value(filtered_extension_imes_.GetValue());
+
+ std::vector<std::string> split_values;
+ if (!value.empty())
+ base::SplitString(value, ',', &split_values);
+
+ input_method_manager_->SetFilteredExtensionImes(split_values);
+ }
+
// Do not check |*pref_name| of the prefs for remembering current/previous
// input methods here. We're only interested in initial values of the prefs.

Powered by Google App Engine
This is Rietveld 408576698