chrome/browser/chromeos/input_method/input_method_manager.h - Issue 10907196: Add the ability to filter out extension IMEs from the language settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager.h

Issue 10907196: Add the ability to filter out extension IMEs from the language settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.h » ('j') | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager.h

diff --git a/chrome/browser/chromeos/input_method/input_method_manager.h b/chrome/browser/chromeos/input_method/input_method_manager.h

index c93d53c155e39f3b203511814f2b6ebb0d7dbe0a..9dba506000737a9fc9120ae239d4d6cbe2ebf65b 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager.h

+++ b/chrome/browser/chromeos/input_method/input_method_manager.h

@@ -129,6 +129,10 @@ class InputMethodManager {

// Removes an input method extension.

virtual void RemoveInputMethodExtension(const std::string& id) = 0;

+ virtual InputMethodDescriptors* GetInputMethodExtensions() = 0;

Seigo Nonaka 2012/09/12 16:50:37 Please add function comments.

Zachary Kuznia 2012/09/13 09:28:32 Done.

+ virtual void SetFilteredExtensionImes(std::vector<std::string>& ids) = 0;

Seigo Nonaka 2012/09/12 16:50:37 ditto and please use pointer instead. http://googl

Zachary Kuznia 2012/09/13 09:28:32 Done.

// Gets the descriptor of the input method which is currently selected.

virtual InputMethodDescriptor GetCurrentInputMethod() const = 0;