Add UMA counter for hung renderers on cross-site navigation.

Add UMA counter for hung renderers on cross-site navigation.


BUG=104346
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161141

[nasko, 2012-09-13 21:27:30]

Reviving the hung renderer change. I've only added the histogram logging,
without actually killing the process.

[Charlie Reis, 2012-09-13 21:50:20]

Ah, yes.  LGTM with nits.

However, we're getting close to branching.  Perhaps we should land this just
after the branch, in case the cause of the previous renderer crashes is in here
somewhere?  (That's what we saw last time, right?  It continued to crash after
the actually line to kill was removed, IIRC.)

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
content/browser/renderer_host/render_view_host_impl.cc:486: // is that there is
no network requests and this code is hit without
nit: there is -> those have

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
content/browser/renderer_host/render_view_host_impl.cc:751: success ?
kUnloadTimeoutMS : hung_renderer_delay_ms_));
nit: Needs braces.

[nasko, 2012-09-13 22:09:30]

Yes, my goal is to commit this once we have branched. Unlike previous attempts
though, I want to have it ready to go :).

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
content/browser/renderer_host/render_view_host_impl.cc:486: // is that there is
no network requests and this code is hit without
On 2012/09/13 21:50:20, creis wrote:
> nit: there is -> those have

Done.

https://chromiumcodereview.appspot.com/10907182/diff/2002/content/browser/ren...
content/browser/renderer_host/render_view_host_impl.cc:751: success ?
kUnloadTimeoutMS : hung_renderer_delay_ms_));
On 2012/09/13 21:50:20, creis wrote:
> nit: Needs braces.

Done.

[commit-bot: I haz the power, 2012-10-10 17:32:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nasko@chromium.org/10907182/16001

[commit-bot: I haz the power, 2012-10-10 19:02:01]

Change committed as 161141