Try to fix the possible bug in base::Time:Now() that can cause the crashing later in icu code calle…

Try to fix the possible bug in base::Time:Now() that can cause the crashing later in icu code called from ash tray TimeView::UpdateTextInternal() if the call to gettimeofday fails.



BUG=147570
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156134

[brettw, 2012-09-11 18:10:23]

http://codereview.chromium.org/10907178/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

http://codereview.chromium.org/10907178/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:187: if (now.ToInternalValue() == 0L) {
Use now.is_null().

http://codereview.chromium.org/10907178/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

http://codereview.chromium.org/10907178/diff/1/base/time_posix.cc#newcode76
base/time_posix.cc:76: return Time(0L);
Use return Time();

[jennyz, 2012-09-11 18:35:21]

http://codereview.chromium.org/10907178/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

http://codereview.chromium.org/10907178/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:187: if (now.ToInternalValue() == 0L) {
On 2012/09/11 18:10:23, brettw wrote:
> Use now.is_null().

Done.

http://codereview.chromium.org/10907178/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

http://codereview.chromium.org/10907178/diff/1/base/time_posix.cc#newcode76
base/time_posix.cc:76: return Time(0L);
On 2012/09/11 18:10:23, brettw wrote:
> Use return Time();

Done.

[brettw, 2012-09-11 19:14:33]

lgtm

[sadrul, 2012-09-11 21:25:34]

lgtm

[commit-bot: I haz the power, 2012-09-11 21:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10907178/4