Issue 10907174: Fix invariant so that we cannot record relocation slots for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907174: Fix invariant so that we cannot record relocation slots for (Closed)

Created:
8 years, 3 months ago by Erik Corry

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix invariant so that we cannot record relocation slots for white objects when compacting. Add flag for incremental code compaction. Committed: https://code.google.com/p/v8/source/detail?r=12483

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -6 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/incremental-marking.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/incremental-marking.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/incremental-marking-inl.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/mark-compact.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 3 months ago (2012-09-11 13:51:12 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10907174/diff/1/src/incremental-marking.h
File src/incremental-marking.h (right):

https://chromiumcodereview.appspot.com/10907174/diff/1/src/incremental-markin...
src/incremental-marking.h:135: // Returns true if you need to record a slot.
Enhance comment:

record a slot for compation. Returns false for objects that are guaranteed to be
rescaned or not guaranteed to survive.

No slots in white objects should be recorded as some slots are typed and cannot
be interpreted corrrectly if the underlying object does not survive incremental
cycle (stays white).

Expand Messages | Collapse Messages