Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 10907172: clang: Remove another unnecessary workaround (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, Johnny(Jianning) Ding
Visibility:
Public.

Description

clang: Remove another unnecessary workaround Older clangs failed to parse tr1::tuple and used gtest's implementation thereof. That's no longer necessary. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/gtest.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 3 months ago (2012-09-11 10:09:50 UTC) #1
hans
lgtm
8 years, 3 months ago (2012-09-11 10:11:52 UTC) #2
hans
On 2012/09/11 10:11:52, hans wrote: > lgtm To be nitty, maybe the CL description could ...
8 years, 3 months ago (2012-09-11 10:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10907172/1
8 years, 3 months ago (2012-09-11 14:19:47 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 16:37:48 UTC) #5
Change committed as 156024

Powered by Google App Engine
This is Rietveld 408576698