Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 10907170: Show composition window for IME-unaware PPAPI plugins on Windows. (Closed)

Created:
8 years, 3 months ago by kinaba
Modified:
8 years, 2 months ago
Reviewers:
James Su, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Show composition window for IME-unaware PPAPI plugins on Windows. When a PPAPI plugin does not support drawing composition text by themselves, outer environment is expected to do it instead. This patch implements it on Windows. BUG=97189 TEST=Manual test by a dummy plugin. 1. ninja -C out/Debug chrome ppapi_example_ime 2. out/Debug/chrome --register-pepper-plugins='/path/to/ppapi_example_ime.dll;application/x-ppapi-example-ime' file:///path/to/ppapi/example/ime/ime.html 3. type some text via IME on 2nd and 3rd plugin widget. 4. verify pre-edit composition text is displayed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158756

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Style fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 5 chunks +17 lines, -7 lines 0 comments Download
M ui/base/win/ime_input.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/base/win/ime_input.cc View 4 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
+suzhe Could you take a look at this patch? I'm sorry for asking this time-leaping ...
8 years, 2 months ago (2012-09-24 10:57:08 UTC) #1
James Su
LGTM, assuming you have tested it. On 2012/09/24 10:57:08, kinaba wrote: > +suzhe > > ...
8 years, 2 months ago (2012-09-24 15:35:54 UTC) #2
kinaba
+sky, for OWNER approval for ui/ and chrome/. Thanks, James. I've manually verified it working ...
8 years, 2 months ago (2012-09-25 00:55:02 UTC) #3
sky
LGTM http://codereview.chromium.org/10907170/diff/11001/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/10907170/diff/11001/content/browser/renderer_host/render_widget_host_view_win.cc#newcode767 content/browser/renderer_host/render_widget_host_view_win.cc:767: || can_compose_inline_ != params.can_compose_inline) { || on previous ...
8 years, 2 months ago (2012-09-25 15:46:18 UTC) #4
kinaba
http://codereview.chromium.org/10907170/diff/11001/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/10907170/diff/11001/content/browser/renderer_host/render_widget_host_view_win.cc#newcode767 content/browser/renderer_host/render_widget_host_view_win.cc:767: || can_compose_inline_ != params.can_compose_inline) { On 2012/09/25 15:46:18, sky ...
8 years, 2 months ago (2012-09-26 01:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10907170/18002
8 years, 2 months ago (2012-09-26 02:00:29 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 05:47:43 UTC) #7
Change committed as 158756

Powered by Google App Engine
This is Rietveld 408576698