[gtk] When mouse is inside of an auto-closing zoom bubble and the zoom is

[gtk] When mouse is inside of an auto-closing zoom bubble and the zoom is
changed again, a timer is restarted and closes the bubble (not desired).

R=estade@chromium.org
BUG=None
TEST=Zoom, put mouse inside bubble, zoom again - bubble should not auto-close.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156068

[Dan Beam, 2012-09-11 07:43:21]

if this LG feel free to CQ, btw

[Evan Stade, 2012-09-11 08:28:56]

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
File chrome/browser/ui/gtk/zoom_bubble_gtk.cc (right):

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
chrome/browser/ui/gtk/zoom_bubble_gtk.cc:160: if (auto_close_ && !mouse_inside_)
{
prefer

if (!auto_close_ || mouse_inside_)
  return;

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
chrome/browser/ui/gtk/zoom_bubble_gtk.cc:206: mouse_inside_ = false;
wouldn't you need to put this before StartTimerIfNecessary?

[Dan Beam, 2012-09-11 16:33:41]

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
File chrome/browser/ui/gtk/zoom_bubble_gtk.cc (right):

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
chrome/browser/ui/gtk/zoom_bubble_gtk.cc:160: if (auto_close_ && !mouse_inside_)
{
On 2012/09/11 08:28:56, Evan Stade wrote:
> prefer
> 
> if (!auto_close_ || mouse_inside_)
>   return;

Done.

http://codereview.chromium.org/10907168/diff/4/chrome/browser/ui/gtk/zoom_bub...
chrome/browser/ui/gtk/zoom_bubble_gtk.cc:206: mouse_inside_ = false;
On 2012/09/11 08:28:56, Evan Stade wrote:
> wouldn't you need to put this before StartTimerIfNecessary?

Done.

[Evan Stade, 2012-09-11 16:35:09]

lgtm

[commit-bot: I haz the power, 2012-09-11 16:38:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10907168/1003

[commit-bot: I haz the power, 2012-09-11 18:35:53]

Change committed as 156068