Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2390)

Unified Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rtcPrivate fix Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket_apitest.cc
diff --git a/chrome/browser/extensions/api/socket/socket_apitest.cc b/chrome/browser/extensions/api/socket/socket_apitest.cc
index af02f6342b2e426218130f2cb7eeeb6b96d8a70f..29414d1e76c926792243fa2b1a52289e0951ece3 100644
--- a/chrome/browser/extensions/api/socket/socket_apitest.cc
+++ b/chrome/browser/extensions/api/socket/socket_apitest.cc
@@ -93,22 +93,6 @@ IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPCreateGood) {
ASSERT_TRUE(socketId > 0);
}
-IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketCreateBad) {
- scoped_refptr<extensions::SocketCreateFunction> socket_create_function(
- new extensions::SocketCreateFunction());
- scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
-
- socket_create_function->set_extension(empty_extension.get());
- socket_create_function->set_has_callback(true);
-
- // TODO(miket): this test currently passes only because of artificial code
- // that doesn't run in production. Fix this when we're able to.
- utils::RunFunctionAndReturnError(
- socket_create_function,
- "[\"xxxx\"]",
- browser(), utils::NONE);
-}
-
IN_PROC_BROWSER_TEST_F(SocketApiTest, GetNetworkList) {
scoped_refptr<extensions::SocketGetNetworkListFunction> socket_function(
new extensions::SocketGetNetworkListFunction());

Powered by Google App Engine
This is Rietveld 408576698