Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 10907140: ninja: Survive case-only file renames on case-insensitive filesystems. (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel, scottmg
CC:
gyp-developer_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

ninja: Survive case-only file renames on case-insensitive filesystems. See https://github.com/martine/ninja/issues/402 for more information. Committed: https://code.google.com/p/gyp/source/detail?r=1494

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -4 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 3 4 5 6 7 9 6 chunks +15 lines, -4 lines 2 comments Download
A test/rename/filecase/file.c View 1 chunk +1 line, -0 lines 0 comments Download
A test/rename/filecase/test.gyp View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A test/rename/filecase/test-casesensitive.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +15 lines, -0 lines 0 comments Download
A test/rename/gyptest-filecase.py View 1 2 3 4 5 6 7 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 3 months ago (2012-09-10 09:19:49 UTC) #1
Nico
(Patch set 4 was just the test, without the code change. The test failed on ...
8 years, 3 months ago (2012-09-10 09:21:47 UTC) #2
M-A Ruel
The code lgtm with a question. https://chromiumcodereview.appspot.com/10907140/diff/14009/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/10907140/diff/14009/pylib/gyp/generator/ninja.py#newcode358 pylib/gyp/generator/ninja.py:358: case_sensitive_filesystem): Sorry I'm ...
8 years, 3 months ago (2012-09-10 14:03:13 UTC) #3
scottmg
lgtm
8 years, 3 months ago (2012-09-11 16:46:35 UTC) #4
scottmg
8 years, 3 months ago (2012-09-11 16:47:58 UTC) #5
And yeah, the depdb (incorrectly?) is case-sensitive. On ninja-master with .d
files it'll fail/fix though.

Powered by Google App Engine
This is Rietveld 408576698