Issue 10907129: Parse and resolve new syntax for named parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907129: Parse and resolve new syntax for named parameters. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parse and resolve new syntax for named parameters. Committed: https://code.google.com/p/dart/source/detail?r=12114

Patch Set 1 #

Patch Set 2 : update status files #

Patch Set 3 : Rebased #

Patch Set 4 : Update status files #

Patch Set 5 : Rebased #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	dart/lib/compiler/implementation/resolver.dart	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/scanner/parser.dart	View	1 2 3 4	4 chunks	+15 lines, -6 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 2 3 4	2 chunks	+8 lines, -5 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

This is a bare minimum to allow us to make progress on changing the libraries.

8 years, 3 months ago (2012-09-08 09:33:13 UTC) #1

kasperl

LGTM. Does the co19 tests give us enough coverage of the syntax?

8 years, 3 months ago (2012-09-10 09:22:03 UTC) #2

ahe

8 years, 3 months ago (2012-09-10 13:55:10 UTC) #4

On 2012/09/10 09:22:03, kasperl wrote:
> LGTM. Does the co19 tests give us enough coverage of the syntax?

I think there is enough coverage to submit this as is.

Expand Messages | Collapse Messages