chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc - Issue 10907121: Add guards to metric values; erase bad events/metrics from db

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

Issue 10907121: Add guards to metric values; erase bad events/metrics from db (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_use_units

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/performance_monitor/metric.cc ('K') | « chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.h ('k') | chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

index b0c29a809b0bc83271a624384ea5b27b14319161..4f1d0f8d7ce39aed8ed3122a071a2ca21bf4704c 100644

--- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

+++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.cc

@@ -20,6 +20,7 @@ double GetConversionFactor(UnitDetails from, UnitDetails to) {

}

scoped_ptr<Database::MetricVector> AggregateMetric(

+ MetricType type,

const Database::MetricVector* metrics,

const base::Time& start,

const base::TimeDelta& resolution) {

@@ -55,7 +56,7 @@ scoped_ptr<Database::MetricVector> AggregateMetric(

// at the end of the window.

integrated += metric_value * (window_end - last_sample_time).InSecondsF();

double average = integrated / resolution.InSecondsF();

- results->push_back(Metric(window_end, average));

+ results->push_back(Metric(type, window_end, average));

}

return results.Pass();

}