Add guards to metric values; erase bad events/metrics from db

chrome/browser/performance_monitor/metric.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERFORMANCE_MONITOR_METRIC_H_
 #define CHROME_BROWSER_PERFORMANCE_MONITOR_METRIC_H_
 
 #include <string>
 #include "base/time.h"
 
@@ skipping 14 matching lines @@
 METRIC_TEST_STARTUP_TIME,
 METRIC_SESSION_RESTORE_TIME,
 METRIC_PAGE_LOAD_TIME,
 METRIC_NETWORK_BYTES_READ,
 METRIC_NUMBER_OF_METRICS
 };
 
 struct Metric {
  public:
   Metric();
-  Metric(const base::Time& metric_time, const double metric_value);
-  Metric(const std::string& metric_time, const std::string& metric_value);
+  Metric(MetricType metric_type,
+         const base::Time& metric_time,
+         const double metric_value);
+  Metric(MetricType metric_type,
+         const std::string& metric_time,
+         const std::string& metric_value);
   ~Metric();
 
+  // Check the value in the metric to make sure that it is reasonable. Since
+  // some metric-gathering methods will fail and return incorrect values, we
+  // need to try to weed these out as best we can.
+  bool Validate() const;

[Yoyo Zhou, 2012/09/10 23:52:44]

This should be called something like IsValid.

[Devlin, 2012/09/11 18:52:17]

Done.

+
+  std::string ValueAsString() const;

[Yoyo Zhou, 2012/09/10 23:52:44]

Does this make sense if the metric isn't valid? If not, document it as such.

[Devlin, 2012/09/11 18:52:17]

Done.

[Yoyo Zhou, 2012/09/13 00:09:20]

I was hoping more for something like, "This only makes sense if IsValid."

[Devlin, 2012/09/13 17:00:24]

Done.

+
+  MetricType type;
   base::Time time;
   double value;
 };
 
 }  // namespace performance_monitor
 
 #endif  // CHROME_BROWSER_PERFORMANCE_MONITOR_METRIC_H_