[Sync] Rename classes in sync/ that start with Chrome

tools/valgrind/memcheck/suppressions.txt

 # There are four kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 5269 matching lines @@
    fun:_ZN4base6Thread10ThreadMainEv
    fun:_ZN4base12_GLOBAL__N_110ThreadFuncEPv
 }
 {
    bug_130362
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN12invalidation20NewPermanentCallbackINS_22InvalidationClientImplES1_St4pairINS_6StatusESsEEEPN4base8CallbackIFvT1_EEEPT_MT0_FvS7_E
    fun:_ZN12invalidation22InvalidationClientImpl34ScheduleStartAfterReadingStateBlobEv
    fun:_ZN12invalidation22InvalidationClientImpl5StartEv
-   fun:_ZN13sync_notifier24ChromeInvalidationClient5StartERKSsS2_S2_RKSt3mapIN8syncable9ModelTypeElSt4lessIS5_ESaISt4pairIKS5_lEEERKN12browser_sync10WeakHandleINS_24InvalidationStateTrackerEEEPNS0_8ListenerEPNS_11StateWriterE
+   fun:_ZN13sync_notifier24SyncInvalidationClient5StartERKSsS2_S2_RKSt3mapIN8syncable9ModelTypeElSt4lessIS5_ESaISt4pairIKS5_lEEERKN12browser_sync10WeakHandleINS_24InvalidationStateTrackerEEEPNS0_8ListenerEPNS_11StateWriterE

[rlarocque, 2012/09/05 00:58:31]

Good catch.  I would not have thought to look here.

Unfortunately, this might not be enough.  I can successfully decode the old name
using c++filt, but not the new one.  That suggests your change has produced an
invalid mangled name.

Did this name come from the binary itself?  If not, you should check it against
the symbols in your binary, just to be sure.

    fun:_ZN13sync_notifier20InvalidationNotifier17UpdateCredentialsERKSsS2_
    fun:_ZN13sync_notifier31NonBlockingInvalidationNotifier4Core17UpdateCredentialsERKSsS3_
 }
 {
    bug_130449
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN12invalidation20NewPermanentCallbackINS_22InvalidationClientImplES1_St4pairINS_6StatusESsEEEPN4base8CallbackIFvT1_EEEPT_MT0_FvS7_E
    fun:_ZN12invalidation22InvalidationClientImpl34ScheduleStartAfterReadingStateBlobEv
    fun:_ZN12invalidation22InvalidationClientImpl5StartEv
-   fun:_ZN13sync_notifier24ChromeInvalidationClient5StartERKSsS2_S2_RKSt3mapIN8syncable9ModelTypeElSt4lessIS5_ESaISt4pairIKS5_lEEERKN12browser_sync10WeakHandleINS_24InvalidationStateTrackerEEEPNS0_8ListenerE
+   fun:_ZN13sync_notifier24SyncInvalidationClient5StartERKSsS2_S2_RKSt3mapIN8syncable9ModelTypeElSt4lessIS5_ESaISt4pairIKS5_lEEERKN12browser_sync10WeakHandleINS_24InvalidationStateTrackerEEEPNS0_8ListenerE
    fun:_ZN13sync_notifier20InvalidationNotifier17UpdateCredentialsERKSsS2_
    fun:_ZN13sync_notifier31NonBlockingInvalidationNotifier4Core17UpdateCredentialsERKSsS3_
 }
 {
    bug_130619
    Memcheck:Leak
    fun:_Znw*
    fun:_ZN7WebCore9ClipRects6createERKS0_
    fun:_ZN7WebCore11RenderLayer15updateClipRectsEPKS0_PNS_12RenderRegionENS_13ClipRectsTypeENS_29OverlayScrollbarSizeRelevancyE
    ...
@@ skipping 688 matching lines @@
    obj:/lib/libselinux.so.1
    obj:/lib/libselinux.so.1
 }
 {
    bug_todo_grep
    Memcheck:Leak
    fun:malloc
    obj:/bin/grep
    obj:/bin/grep
 }