Issue 10907060: Files app test harness improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907060: Files app test harness improvements. (Closed)

Created:
8 years, 3 months ago by Vladislav Kaznacheev

Modified:
8 years, 3 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files app test harness improvements. Added a dedicated zero-setup harness for the Gallery. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155144

Patch Set 2 : Addressed comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -48 lines)			Patch
A	chrome/browser/resources/file_manager/gallery_harness.html	View		1 chunk	+95 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/harness.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/harness.js	View	1	6 chunks	+137 lines, -43 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM https://chromiumcodereview.appspot.com/10907060/diff/1/chrome/browser/resources/file_manager/js/harness.js File chrome/browser/resources/file_manager/js/harness.js (right): https://chromiumcodereview.appspot.com/10907060/diff/1/chrome/browser/resources/file_manager/js/harness.js#newcode147 chrome/browser/resources/file_manager/js/harness.js:147: * Copy a blob into into the filesystem. ...

8 years, 3 months ago (2012-09-05 08:14:04 UTC) #2

Vladislav Kaznacheev

8 years, 3 months ago (2012-09-06 08:28:45 UTC) #3

https://chromiumcodereview.appspot.com/10907060/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/harness.js (right):

https://chromiumcodereview.appspot.com/10907060/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/harness.js:147: * Copy a blob into into
the filesystem.
On 2012/09/05 08:14:05, dgozman wrote:
> into into

Done.

Expand Messages | Collapse Messages

Issue 10907060: Files app test harness improvements. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages