Issue 10907049: Fix windows compile errors introduced by r12430.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907049: Fix windows compile errors introduced by r12430. (Closed)

Created:
8 years, 3 months ago by Yang

Modified:
8 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix windows compile errors introduced by r12430. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12432

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/api.cc	View		1 chunk	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years, 3 months ago (2012-09-03 15:38:21 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10907049/diff/1/src/api.cc
File src/api.cc (right):

https://chromiumcodereview.appspot.com/10907049/diff/1/src/api.cc#newcode4951
src/api.cc:4951: i::String::IsAscii(resource->data(),
One more space so that "i" aligns with "a".

Expand Messages | Collapse Messages