Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 10907045: Fix the leaks in TestHyphenatorMessageFilter::OnOpenDictionary(). (Closed)

Created:
8 years, 3 months ago by Hironori Bono
Modified:
8 years, 3 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, darin-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix the leaks in TestHyphenatorMessageFilter::OnOpenDictionary(). This change deletes IPC messages received in TestHyphenatorMessageFilter::OnMessage() to delete HyphenatorMsg_SetDictionary messages sent by TestHyphenatorMessageFilter::OnOpenDictionary(). BUG=146222 TEST=the memory bots are green without suppressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154900

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M content/browser/hyphenator/hyphenator_message_filter_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
Greetings John and Avi, Unfortunately, my r154663 <http://crrev.com/154663> forgot deleting IPC messages in its unit ...
8 years, 3 months ago (2012-09-04 08:23:24 UTC) #1
jam
lgtm
8 years, 3 months ago (2012-09-04 17:01:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10907045/1
8 years, 3 months ago (2012-09-05 02:45:43 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/memcheck/suppressions.txt: While running patch -p0 --forward --force; patching file tools/valgrind/memcheck/suppressions.txt ...
8 years, 3 months ago (2012-09-05 02:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10907045/13001
8 years, 3 months ago (2012-09-05 03:41:53 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 06:06:07 UTC) #6
Change committed as 154900

Powered by Google App Engine
This is Rietveld 408576698