Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/system/power/tray_power.h

Issue 10907037: Only update system power indicators on change (Closed) Base URL: https://git.chromium.org/git/chromium/src@git-svn
Patch Set: Updated comments, rebased to ToT, moved textfield opts to separte CL Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/system/power/power_status_view.cc ('K') | « ash/system/power/power_status_view.cc ('k') | ash/system/power/tray_power.cc » ('j') | ash/system/power/tray_power.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/power/tray_power.h
diff --git a/ash/system/power/tray_power.h b/ash/system/power/tray_power.h
index 44324fe9dcfd73c0a01a9894cb47c13d46ed39c2..32f616fd6de479e7450b113727014cf0d76a4a2f 100644
--- a/ash/system/power/tray_power.h
+++ b/ash/system/power/tray_power.h
@@ -33,11 +33,12 @@ class TrayPower : public SystemTrayItem,
TrayPower();
virtual ~TrayPower();
- // Gets battery image based on |supply_status|. If |supply_status| is
- // uncertain about the power state, return |default_image| instead.
- static gfx::ImageSkia GetBatteryImage(const PowerSupplyStatus& supply_status,
- IconSet icon_set,
- const gfx::ImageSkia& default_image);
+ // Get the icon index in the battery icon array image based on
Daniel Erat 2012/09/11 22:17:09 s/Get/Gets/
+ // |supply_status|. If |supply_status| is uncertain about the power state,
+ // return -1.
Daniel Erat 2012/09/11 22:17:09 s/return/returns/
+ static int GetBatteryImageIndex(const PowerSupplyStatus& supply_status);
+ // Lookup the actual icon in the icon array image for |image_index|.
Daniel Erat 2012/09/11 22:17:09 add a blank line before this one s/Lookup/Looks u
+ static gfx::ImageSkia GetBatteryImage(int image_index, IconSet icon_set);
private:
enum NotificationState {
« ash/system/power/power_status_view.cc ('K') | « ash/system/power/power_status_view.cc ('k') | ash/system/power/tray_power.cc » ('j') | ash/system/power/tray_power.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698