Only update system power indicators on change

ash/system/power/tray_power.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/power/tray_power.h"
 
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
 #include "ash/system/date/date_view.h"
 #include "ash/system/power/power_status_view.h"
@@ skipping 45 matching lines @@
 const int kLowPowerSeconds = 15 * 60;
 const int kNoWarningSeconds = 30 * 60;
 
 }  // namespace
 
 namespace tray {
 
 // This view is used only for the tray.
 class PowerTrayView : public views::ImageView {
  public:
-  PowerTrayView() {
+  PowerTrayView()
+      : battery_icon_index_(-1) {

[Daniel Erat, 2012/09/11 22:17:09]

nit: move to end of previous line

     UpdateImage();
   }
 
   virtual ~PowerTrayView() {
   }
 
   void UpdatePowerStatus(const PowerSupplyStatus& status) {
     supply_status_ = status;
     // Sanitize.
     if (supply_status_.battery_is_full)
       supply_status_.battery_percentage = 100.0;
 
     UpdateImage();
     SetVisible(status.battery_is_present);
   }
 
  private:
   void UpdateImage() {
-    SetImage(TrayPower::GetBatteryImage(supply_status_, ICON_LIGHT,
-                                        GetImage()));
+    int index = TrayPower::GetBatteryImageIndex(supply_status_);
+    if (battery_icon_index_ != index) {
+      battery_icon_index_ = index;
+      if (battery_icon_index_ == -1)
+        SetImage(GetImage());

[Daniel Erat, 2012/09/11 22:17:09]

don't understand this either

+      else
+        SetImage(TrayPower::GetBatteryImage(battery_icon_index_, ICON_LIGHT));
+    }
   }
 
   PowerSupplyStatus supply_status_;
 
+  // index of the current icon in the icon array image

[Daniel Erat, 2012/09/11 22:17:09]

nit: capitalize, add period, and mention what -1 means

+  int battery_icon_index_;
+
   DISALLOW_COPY_AND_ASSIGN(PowerTrayView);
 };
 
 class PowerNotificationView : public TrayNotificationView {
  public:
   explicit PowerNotificationView(TrayPower* tray)
-      : TrayNotificationView(tray, 0) {
+      : TrayNotificationView(tray, 0),
+        battery_icon_index_(-1) {
     power_status_view_ =
         new PowerStatusView(PowerStatusView::VIEW_NOTIFICATION, true);
     InitView(power_status_view_);
   }
 
   void UpdatePowerStatus(const PowerSupplyStatus& status) {
-    SetIconImage(TrayPower::GetBatteryImage(status, ICON_DARK,
-                                            GetIconImage()));
+    int index = TrayPower::GetBatteryImageIndex(status);
+    if (battery_icon_index_ != index) {
+      battery_icon_index_ = index;
+      if (battery_icon_index_ == -1)

[Daniel Erat, 2012/09/11 22:17:09]

nit: add curly brackets

+        SetIconImage(GetIconImage());

[Daniel Erat, 2012/09/11 22:17:09]

same as above

+      else
+        SetIconImage(TrayPower::GetBatteryImage(battery_icon_index_,
+                                                ICON_DARK));
+    }
     power_status_view_->UpdatePowerStatus(status);
   }
 
  private:
   PowerStatusView* power_status_view_;
 
+  // index of the current icon in the icon array image

[Daniel Erat, 2012/09/11 22:17:09]

nit: capitalize and period

+  int battery_icon_index_;
+
   DISALLOW_COPY_AND_ASSIGN(PowerNotificationView);
 };
 
 }  // namespace tray
 
 using tray::PowerNotificationView;
 
 TrayPower::TrayPower()
     : power_tray_(NULL),
       notification_view_(NULL),
       notification_state_(NOTIFICATION_NONE) {
 }
 
 TrayPower::~TrayPower() {
 }
 
 // static
-gfx::ImageSkia TrayPower::GetBatteryImage(
-    const PowerSupplyStatus& supply_status,
-    IconSet icon_set,
-    const gfx::ImageSkia& default_image) {
-  gfx::Image all = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
-      icon_set == ICON_DARK ?
-      IDR_AURA_UBER_TRAY_POWER_SMALL_DARK : IDR_AURA_UBER_TRAY_POWER_SMALL);
-
+int TrayPower::GetBatteryImageIndex(const PowerSupplyStatus& supply_status) {
   int image_index = 0;
   if (supply_status.battery_percentage >= 100) {
     image_index = kNumPowerImages - 1;
   } else if (!supply_status.battery_is_present) {
     image_index = kNumPowerImages;
   } else {
     // If power supply is calculating battery time, the battery percentage
-    // is uncertain, just return |default_image|.
+    // is uncertain, just return -1.
     if (supply_status.is_calculating_battery_time)
-      return default_image;
+      return -1;
     image_index = static_cast<int>(supply_status.battery_percentage /
                   100.0 * (kNumPowerImages - 1));
     image_index = std::max(std::min(image_index, kNumPowerImages - 2), 0);
   }
+  return (image_index << 1) | (supply_status.line_power_on ? 1 : 0);
+}
+
+// static
+gfx::ImageSkia TrayPower::GetBatteryImage(int image_index, IconSet icon_set) {
+  gfx::Image all = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+      icon_set == ICON_DARK ?
+      IDR_AURA_UBER_TRAY_POWER_SMALL_DARK : IDR_AURA_UBER_TRAY_POWER_SMALL);
 
   // TODO(mbolohan): Remove the 2px offset when the assets are centered. See
   // crbug.com/119832.
   gfx::Rect region(
-      (supply_status.line_power_on ? kBatteryImageWidth : 0) + 2,
-      image_index * kBatteryImageHeight,
+      ((image_index & 0x1) ? kBatteryImageWidth : 0) + 2,
+      (image_index >> 1) * kBatteryImageHeight,
       kBatteryImageWidth - 2, kBatteryImageHeight);
   return gfx::ImageSkiaOperations::ExtractSubset(*all.ToImageSkia(), region);
 }
 
 views::View* TrayPower::CreateTrayView(user::LoginStatus status) {
   // There may not be enough information when this is created about whether
   // there is a battery or not. So always create this, and adjust visibility as
   // necessary.
   PowerSupplyStatus power_status =
       ash::Shell::GetInstance()->tray_delegate()->GetPowerSupplyStatus();
@@ skipping 87 matching lines @@
       return false;
     case NOTIFICATION_CRITICAL:
       return false;
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace internal
 }  // namespace ash