Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: utils/tests/pub/pub_install_test.dart

Issue 10907036: Hide self-referential symlinks behind a flag in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/pub.dart ('k') | utils/tests/pub/pub_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('pub_tests'); 5 #library('pub_tests');
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 8
9 #import('test_pub.dart'); 9 #import('test_pub.dart');
10 #import('../../../pkg/unittest/unittest.dart'); 10 #import('../../../pkg/unittest/unittest.dart');
(...skipping 15 matching lines...) Expand all
26 ]).scheduleCreate(); 26 ]).scheduleCreate();
27 27
28 schedulePub(args: ['install'], 28 schedulePub(args: ['install'],
29 error: const RegExp(@'^"pubspec.yaml" is missing the required "name" ' 29 error: const RegExp(@'^"pubspec.yaml" is missing the required "name" '
30 @'field \(e\.g\. "name: myapp"\)\.')); 30 @'field \(e\.g\. "name: myapp"\)\.'));
31 31
32 run(); 32 run();
33 }); 33 });
34 }); 34 });
35 35
36 // TODO(rnystrom): Re-enable this when #4820 is fixed.
37 /*
36 test('creates a self-referential symlink', () { 38 test('creates a self-referential symlink', () {
37 // The symlink should use the name in the pubspec, not the name of the 39 // The symlink should use the name in the pubspec, not the name of the
38 // directory. 40 // directory.
39 dir(appPath, [ 41 dir(appPath, [
40 pubspec({"name": "myapp_name"}) 42 pubspec({"name": "myapp_name"})
41 ]).scheduleCreate(); 43 ]).scheduleCreate();
42 44
43 schedulePub(args: ['install'], 45 schedulePub(args: ['install'],
44 output: const RegExp(@"Dependencies installed!$")); 46 output: const RegExp(@"Dependencies installed!$"));
45 47
46 dir(packagesPath, [ 48 dir(packagesPath, [
47 dir("myapp_name", [pubspec({"name": "myapp_name"})]) 49 dir("myapp_name", [pubspec({"name": "myapp_name"})])
48 ]).scheduleValidate(); 50 ]).scheduleValidate();
49 51
50 run(); 52 run();
51 }); 53 });
54 */
52 55
53 group('creates a packages directory in', () { 56 group('creates a packages directory in', () {
54 test('"test/" and its subdirectories', () { 57 test('"test/" and its subdirectories', () {
55 dir(appPath, [ 58 dir(appPath, [
56 appPubspec([]), 59 appPubspec([]),
57 dir("test", [dir("subtest")]) 60 dir("test", [dir("subtest")])
58 ]).scheduleCreate(); 61 ]).scheduleCreate();
59 62
60 schedulePub(args: ['install'], 63 schedulePub(args: ['install'],
61 output: const RegExp(@"Dependencies installed!$")); 64 output: const RegExp(@"Dependencies installed!$"));
62 65
63 dir(appPath, [ 66 dir(appPath, [
64 dir("test", [ 67 dir("test", [
65 dir("packages", [ 68 dir("packages", [
66 dir("myapp", [appPubspec([])]) 69 // TODO(rnystrom): Re-enable this when #4820 is fixed.
70 /*
71 dir("myapp", [appPubspec([])])
72 */
67 ]), 73 ]),
68 dir("subtest", [ 74 dir("subtest", [
69 dir("packages", [ 75 dir("packages", [
70 dir("myapp", [appPubspec([])]) 76 // TODO(rnystrom): Re-enable this when #4820 is fixed.
77 /*
78 dir("myapp", [appPubspec([])])
79 */
71 ]) 80 ])
72 ]) 81 ])
73 ]) 82 ])
74 ]).scheduleValidate(); 83 ]).scheduleValidate();
75 84
76 run(); 85 run();
77 }); 86 });
78 87
79 test('"example/" and its subdirectories', () { 88 test('"example/" and its subdirectories', () {
80 dir(appPath, [ 89 dir(appPath, [
81 appPubspec([]), 90 appPubspec([]),
82 dir("example", [dir("subexample")]) 91 dir("example", [dir("subexample")])
83 ]).scheduleCreate(); 92 ]).scheduleCreate();
84 93
85 schedulePub(args: ['install'], 94 schedulePub(args: ['install'],
86 output: const RegExp(@"Dependencies installed!$")); 95 output: const RegExp(@"Dependencies installed!$"));
87 96
88 dir(appPath, [ 97 dir(appPath, [
89 dir("example", [ 98 dir("example", [
90 dir("packages", [ 99 dir("packages", [
91 dir("myapp", [appPubspec([])]) 100 // TODO(rnystrom): Re-enable this when #4820 is fixed.
101 /*
102 dir("myapp", [appPubspec([])])
103 */
92 ]), 104 ]),
93 dir("subexample", [ 105 dir("subexample", [
94 dir("packages", [ 106 dir("packages", [
95 dir("myapp", [appPubspec([])]) 107 // TODO(rnystrom): Re-enable this when #4820 is fixed.
108 /*
109 dir("myapp", [appPubspec([])])
110 */
96 ]) 111 ])
97 ]) 112 ])
98 ]) 113 ])
99 ]).scheduleValidate(); 114 ]).scheduleValidate();
100 115
101 run(); 116 run();
102 }); 117 });
103 118
104 test('"bin/"', () { 119 test('"bin/"', () {
105 dir(appPath, [ 120 dir(appPath, [
106 appPubspec([]), 121 appPubspec([]),
107 dir("bin") 122 dir("bin")
108 ]).scheduleCreate(); 123 ]).scheduleCreate();
109 124
110 schedulePub(args: ['install'], 125 schedulePub(args: ['install'],
111 output: const RegExp(@"Dependencies installed!$")); 126 output: const RegExp(@"Dependencies installed!$"));
112 127
113 dir(appPath, [ 128 dir(appPath, [
114 dir("bin", [ 129 dir("bin", [
115 dir("packages", [ 130 dir("packages", [
116 dir("myapp", [appPubspec([])]) 131 // TODO(rnystrom): Re-enable this when #4820 is fixed.
132 /*
133 dir("myapp", [appPubspec([])])
134 */
117 ]) 135 ])
118 ]) 136 ])
119 ]).scheduleValidate(); 137 ]).scheduleValidate();
120 138
121 run(); 139 run();
122 }); 140 });
123 }); 141 });
124 } 142 }
OLDNEW
« no previous file with comments | « utils/pub/pub.dart ('k') | utils/tests/pub/pub_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698