Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4088)

Unified Diff: chrome/renderer/autofill/password_generation_manager.cc

Issue 10907021: Fix a memory leak in PasswordGenerationManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/renderer/document_state.h » ('j') | tools/valgrind/memcheck/suppressions.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/password_generation_manager.cc
diff --git a/chrome/renderer/autofill/password_generation_manager.cc b/chrome/renderer/autofill/password_generation_manager.cc
index 767e55153a3f9c8cc4a689dad9683fb04c978692..ef14059ca2f265898c65cfe75b93e07c2bf256c4 100644
--- a/chrome/renderer/autofill/password_generation_manager.cc
+++ b/chrome/renderer/autofill/password_generation_manager.cc
@@ -165,10 +165,10 @@ WebKit::WebCString PasswordGenerationManager::imageNameForReadOnlyState() {
void PasswordGenerationManager::handleClick(WebKit::WebInputElement& element) {
gfx::Rect rect(element.decorationElementFor(this).boundsInViewportSpace());
- webkit::forms::PasswordForm* password_form(
+ scoped_ptr<webkit::forms::PasswordForm> password_form(
webkit::forms::PasswordFormDomManager::CreatePasswordForm(
element.form()));
- if (password_form) {
+ if (password_form.get()) {
Send(new AutofillHostMsg_ShowPasswordGenerationPopup(routing_id(),
rect,
element.maxLength(),
« no previous file with comments | « no previous file | content/public/renderer/document_state.h » ('j') | tools/valgrind/memcheck/suppressions.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698