Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 10907016: Fix CommandLine usage (Closed)

Created:
8 years, 3 months ago by gone
Modified:
8 years, 3 months ago
Reviewers:
James Hawkins, Xianzhu
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix CommandLine usage The Android version was using the CommandLine class incorrectly, leading to a unit test failure on the Android ASAN bot. BUG=145606 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/common/chrome_content_client_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gone
Upstreaming the test fix.
8 years, 3 months ago (2012-08-30 21:44:53 UTC) #1
Xianzhu
lgtm. I think it also needs approval from someone in chrome/OWNERS.
8 years, 3 months ago (2012-08-30 21:48:18 UTC) #2
gone
Hey James, could you give this a lookover?
8 years, 3 months ago (2012-08-30 22:37:15 UTC) #3
James Hawkins
lgtm
8 years, 3 months ago (2012-08-30 22:39:16 UTC) #4
gone
On 2012/08/30 22:39:16, James Hawkins wrote: > lgtm Thanks!
8 years, 3 months ago (2012-08-30 22:59:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/10907016/1
8 years, 3 months ago (2012-08-30 23:00:26 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 04:58:11 UTC) #7
Change committed as 154377

Powered by Google App Engine
This is Rietveld 408576698