Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 10905308: Do not go to slow mode and back to fast in initializer blocks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2111 // Non-initializing assignments to consts are ignored. 2111 // Non-initializing assignments to consts are ignored.
2112 } 2112 }
2113 2113
2114 2114
2115 void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) { 2115 void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) {
2116 // Assignment to a property, using a named store IC. 2116 // Assignment to a property, using a named store IC.
2117 Property* prop = expr->target()->AsProperty(); 2117 Property* prop = expr->target()->AsProperty();
2118 ASSERT(prop != NULL); 2118 ASSERT(prop != NULL);
2119 ASSERT(prop->key()->AsLiteral() != NULL); 2119 ASSERT(prop->key()->AsLiteral() != NULL);
2120 2120
2121 // If the assignment starts a block of assignments to the same object,
2122 // change to slow case to avoid the quadratic behavior of repeatedly
2123 // adding fast properties.
2124 if (expr->starts_initialization_block()) {
2125 __ push(result_register());
2126 __ push(Operand(rsp, kPointerSize)); // Receiver is now under value.
2127 __ CallRuntime(Runtime::kToSlowProperties, 1);
2128 __ pop(result_register());
2129 }
2130
2131 // Record source code position before IC call. 2121 // Record source code position before IC call.
2132 SetSourcePosition(expr->position()); 2122 SetSourcePosition(expr->position());
2133 __ Move(rcx, prop->key()->AsLiteral()->handle()); 2123 __ Move(rcx, prop->key()->AsLiteral()->handle());
2134 if (expr->ends_initialization_block()) { 2124 __ pop(rdx);
2135 __ movq(rdx, Operand(rsp, 0));
2136 } else {
2137 __ pop(rdx);
2138 }
2139 Handle<Code> ic = is_classic_mode() 2125 Handle<Code> ic = is_classic_mode()
2140 ? isolate()->builtins()->StoreIC_Initialize() 2126 ? isolate()->builtins()->StoreIC_Initialize()
2141 : isolate()->builtins()->StoreIC_Initialize_Strict(); 2127 : isolate()->builtins()->StoreIC_Initialize_Strict();
2142 CallIC(ic, RelocInfo::CODE_TARGET, expr->AssignmentFeedbackId()); 2128 CallIC(ic, RelocInfo::CODE_TARGET, expr->AssignmentFeedbackId());
2143 2129
2144 // If the assignment ends an initialization block, revert to fast case.
2145 if (expr->ends_initialization_block()) {
2146 __ push(rax); // Result of assignment, saved even if not needed.
2147 __ push(Operand(rsp, kPointerSize)); // Receiver is under value.
2148 __ CallRuntime(Runtime::kToFastProperties, 1);
2149 __ pop(rax);
2150 __ Drop(1);
2151 }
2152 PrepareForBailoutForId(expr->AssignmentId(), TOS_REG); 2130 PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
2153 context()->Plug(rax); 2131 context()->Plug(rax);
2154 } 2132 }
2155 2133
2156 2134
2157 void FullCodeGenerator::EmitKeyedPropertyAssignment(Assignment* expr) { 2135 void FullCodeGenerator::EmitKeyedPropertyAssignment(Assignment* expr) {
2158 // Assignment to a property, using a keyed store IC. 2136 // Assignment to a property, using a keyed store IC.
2159 2137
2160 // If the assignment starts a block of assignments to the same object,
2161 // change to slow case to avoid the quadratic behavior of repeatedly
2162 // adding fast properties.
2163 if (expr->starts_initialization_block()) {
2164 __ push(result_register());
2165 // Receiver is now under the key and value.
2166 __ push(Operand(rsp, 2 * kPointerSize));
2167 __ CallRuntime(Runtime::kToSlowProperties, 1);
2168 __ pop(result_register());
2169 }
2170
2171 __ pop(rcx); 2138 __ pop(rcx);
2172 if (expr->ends_initialization_block()) { 2139 __ pop(rdx);
2173 __ movq(rdx, Operand(rsp, 0)); // Leave receiver on the stack for later.
2174 } else {
2175 __ pop(rdx);
2176 }
2177 // Record source code position before IC call. 2140 // Record source code position before IC call.
2178 SetSourcePosition(expr->position()); 2141 SetSourcePosition(expr->position());
2179 Handle<Code> ic = is_classic_mode() 2142 Handle<Code> ic = is_classic_mode()
2180 ? isolate()->builtins()->KeyedStoreIC_Initialize() 2143 ? isolate()->builtins()->KeyedStoreIC_Initialize()
2181 : isolate()->builtins()->KeyedStoreIC_Initialize_Strict(); 2144 : isolate()->builtins()->KeyedStoreIC_Initialize_Strict();
2182 CallIC(ic, RelocInfo::CODE_TARGET, expr->AssignmentFeedbackId()); 2145 CallIC(ic, RelocInfo::CODE_TARGET, expr->AssignmentFeedbackId());
2183 2146
2184 // If the assignment ends an initialization block, revert to fast case.
2185 if (expr->ends_initialization_block()) {
2186 __ pop(rdx);
2187 __ push(rax); // Result of assignment, saved even if not needed.
2188 __ push(rdx);
2189 __ CallRuntime(Runtime::kToFastProperties, 1);
2190 __ pop(rax);
2191 }
2192
2193 PrepareForBailoutForId(expr->AssignmentId(), TOS_REG); 2147 PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
2194 context()->Plug(rax); 2148 context()->Plug(rax);
2195 } 2149 }
2196 2150
2197 2151
2198 void FullCodeGenerator::VisitProperty(Property* expr) { 2152 void FullCodeGenerator::VisitProperty(Property* expr) {
2199 Comment cmnt(masm_, "[ Property"); 2153 Comment cmnt(masm_, "[ Property");
2200 Expression* key = expr->key(); 2154 Expression* key = expr->key();
2201 2155
2202 if (key->IsPropertyName()) { 2156 if (key->IsPropertyName()) {
(...skipping 2357 matching lines...) Expand 10 before | Expand all | Expand 10 after
4560 *context_length = 0; 4514 *context_length = 0;
4561 return previous_; 4515 return previous_;
4562 } 4516 }
4563 4517
4564 4518
4565 #undef __ 4519 #undef __
4566 4520
4567 } } // namespace v8::internal 4521 } } // namespace v8::internal
4568 4522
4569 #endif // V8_TARGET_ARCH_X64 4523 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698