Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Side by Side Diff: lib/compiler/implementation/native_handler.dart

Issue 10905305: Patch refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Replaced includeInjectedMembers by implementation Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('native'); 5 #library('native');
6 #import('dart:uri'); 6 #import('dart:uri');
7 #import('leg.dart'); 7 #import('leg.dart');
8 #import('elements/elements.dart'); 8 #import('elements/elements.dart');
9 #import('js_backend/js_backend.dart'); 9 #import('js_backend/js_backend.dart');
10 #import('scanner/scannerlib.dart'); 10 #import('scanner/scannerlib.dart');
(...skipping 22 matching lines...) Expand all
33 cls.superclass, 33 cls.superclass,
34 () => <ClassElement>[]); 34 () => <ClassElement>[]);
35 directSubtypes.add(cls); 35 directSubtypes.add(cls);
36 } 36 }
37 37
38 void processNativeClassesInLibrary(Enqueuer world, 38 void processNativeClassesInLibrary(Enqueuer world,
39 CodeEmitterTask emitter, 39 CodeEmitterTask emitter,
40 LibraryElement library) { 40 LibraryElement library) {
41 bool hasNativeClass = false; 41 bool hasNativeClass = false;
42 final compiler = emitter.compiler; 42 final compiler = emitter.compiler;
43 for (Link<Element> link = library.localMembers; 43 // Use implementation to ensure the inclusion of injected members.
44 !link.isEmpty(); link = link.tail) { 44 library.implementation.forEachLocalMember((Element element) {
45 Element element = link.head;
46 if (element.kind == ElementKind.CLASS) { 45 if (element.kind == ElementKind.CLASS) {
47 ClassElement classElement = element; 46 ClassElement classElement = element;
48 if (classElement.isNative()) { 47 if (classElement.isNative()) {
49 hasNativeClass = true; 48 hasNativeClass = true;
50 world.registerInstantiatedClass(classElement); 49 world.registerInstantiatedClass(classElement);
51 // Also parse the node to know all its methods because 50 // Also parse the node to know all its methods because
52 // otherwise it will only be parsed if there is a call to 51 // otherwise it will only be parsed if there is a call to
53 // one of its constructor. 52 // one of its constructor.
54 classElement.parseNode(compiler); 53 classElement.parseNode(compiler);
55 // Resolve to setup the inheritance. 54 // Resolve to setup the inheritance.
56 classElement.ensureResolved(compiler); 55 classElement.ensureResolved(compiler);
57 // Add the information that this class is a subtype of 56 // Add the information that this class is a subtype of
58 // its supertypes. The code emitter and the ssa builder use that 57 // its supertypes. The code emitter and the ssa builder use that
59 // information. 58 // information.
60 addSubtypes(classElement, emitter.nativeEmitter); 59 addSubtypes(classElement, emitter.nativeEmitter);
61 } 60 }
62 } 61 }
63 } 62 });
64 if (hasNativeClass) { 63 if (hasNativeClass) {
65 world.registerStaticUse(compiler.findHelper( 64 world.registerStaticUse(compiler.findHelper(
66 const SourceString('dynamicFunction'))); 65 const SourceString('dynamicFunction')));
67 world.registerStaticUse(compiler.findHelper( 66 world.registerStaticUse(compiler.findHelper(
68 const SourceString('dynamicSetMetadata'))); 67 const SourceString('dynamicSetMetadata')));
69 world.registerStaticUse(compiler.findHelper( 68 world.registerStaticUse(compiler.findHelper(
70 const SourceString('defineProperty'))); 69 const SourceString('defineProperty')));
71 world.registerStaticUse(compiler.findHelper( 70 world.registerStaticUse(compiler.findHelper(
72 const SourceString('toStringForNativeObject'))); 71 const SourceString('toStringForNativeObject')));
73 world.registerStaticUse(compiler.findHelper( 72 world.registerStaticUse(compiler.findHelper(
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 String parameters) { 330 String parameters) {
332 buffer.add(" if (Object.getPrototypeOf(this).hasOwnProperty"); 331 buffer.add(" if (Object.getPrototypeOf(this).hasOwnProperty");
333 buffer.add("('$methodName')) {\n"); 332 buffer.add("('$methodName')) {\n");
334 buffer.add(" $code"); 333 buffer.add(" $code");
335 buffer.add(" } else {\n"); 334 buffer.add(" } else {\n");
336 buffer.add(" return Object.prototype.$methodName.call(this"); 335 buffer.add(" return Object.prototype.$methodName.call(this");
337 buffer.add(parameters == '' ? '' : ', $parameters'); 336 buffer.add(parameters == '' ? '' : ', $parameters');
338 buffer.add(");\n"); 337 buffer.add(");\n");
339 buffer.add(" }\n"); 338 buffer.add(" }\n");
340 } 339 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698