Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5619)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 10905301: Switch CoreTabHelper to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index a428f3efe9ec4aa921219b539f44ad4a4553a60c..9a8bb93a523a631a3265a5f034d170697fd4ae6b 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -1149,13 +1149,14 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
return source_web_contents_->GetController().CanGoForward();
case IDC_RELOAD: {
- TabContents* tab_contents =
- TabContents::FromWebContents(source_web_contents_);
- if (!tab_contents)
+ CoreTabHelper* core_tab_helper =
+ CoreTabHelper::FromWebContents(source_web_contents_);
+ if (!core_tab_helper)
return false;
- CoreTabHelperDelegate* core_delegate =
- tab_contents->core_tab_helper()->delegate();
- return !core_delegate || core_delegate->CanReloadContents(tab_contents);
+
+ CoreTabHelperDelegate* core_delegate = core_tab_helper->delegate();
+ return !core_delegate ||
+ core_delegate->CanReloadContents(source_web_contents_);
}
case IDC_VIEW_SOURCE:
@@ -1293,14 +1294,14 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
return true;
case IDC_SAVE_PAGE: {
- TabContents* tab_contents =
- TabContents::FromWebContents(source_web_contents_);
- if (!tab_contents)
+ CoreTabHelper* core_tab_helper =
+ CoreTabHelper::FromWebContents(source_web_contents_);
+ if (!core_tab_helper)
return false;
- CoreTabHelperDelegate* core_delegate =
- tab_contents->core_tab_helper()->delegate();
- if (core_delegate && !core_delegate->CanSaveContents(tab_contents))
+ CoreTabHelperDelegate* core_delegate = core_tab_helper->delegate();
+ if (core_delegate &&
+ !core_delegate->CanSaveContents(source_web_contents_))
return false;
PrefService* local_state = g_browser_process->local_state();
« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698