Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 10905299: Fix bug in setting IOThread::Globals (Closed)

Created:
8 years, 3 months ago by szager1
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix bug in setting IOThread::Globals Thanks to mmoss for the catch and willchan for the debug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157038

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
szager1
8 years, 3 months ago (2012-09-14 22:54:18 UTC) #1
willchan no longer on Chromium
lgtm
8 years, 3 months ago (2012-09-14 22:56:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10905299/1
8 years, 3 months ago (2012-09-14 22:57:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 10905299-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-14 22:57:28 UTC) #4
szager1
Adding Nico for chrome/
8 years, 3 months ago (2012-09-14 22:59:42 UTC) #5
Nico
lgtm :-/
8 years, 3 months ago (2012-09-15 13:07:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10905299/1
8 years, 3 months ago (2012-09-15 13:07:59 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-15 15:28:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10905299/9001
8 years, 3 months ago (2012-09-16 00:07:59 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-16 04:01:00 UTC) #10
Change committed as 157038

Powered by Google App Engine
This is Rietveld 408576698