Keep a web dialog window centered over the content area

Keep a web dialog window centered over the content area


BUG=147582
TEST=visual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157072

[Mr4D (OOO till 08-26), 2012-09-14 17:03:28]

Hello Sky!

as discussed - here is the fix to keep the window centered. Please have a look!

Cheers,
-Stefan

[sky, 2012-09-14 17:23:20]

http://codereview.chromium.org/10905290/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_aura.cc (right):

http://codereview.chromium.org/10905290/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_aura.cc:495: for (size_t i = 1; i
< window_->children().size(); i++) {
Now you've got me worried. Add a property that is only set by constrained
windows so you know you're setting the bounds of something you intend to.

[Mr4D (OOO till 08-26), 2012-09-14 20:44:03]

Please have another look!

http://codereview.chromium.org/10905290/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_aura.cc (right):

http://codereview.chromium.org/10905290/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_aura.cc:495: for (size_t i = 1; i
< window_->children().size(); i++) {
Aha! I knew it! :) Done.

[sky, 2012-09-14 22:50:44]

http://codereview.chromium.org/10905290/diff/4003/ui/aura/window.h
File ui/aura/window.h (right):

http://codereview.chromium.org/10905290/diff/4003/ui/aura/window.h#newcode363
ui/aura/window.h:363: void set_is_constrained_window(bool is_constrained_window)
{
Window shouldn't contain chrome specific properties like this. By property I
meant something via SetProperty.

[Mr4D (OOO till 08-26), 2012-09-15 00:14:27]

Okay. Done. Please have another look!

[sky, 2012-09-16 23:25:07]

LGTM

[commit-bot: I haz the power, 2012-09-17 00:38:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10905290/14004

[commit-bot: I haz the power, 2012-09-17 03:18:53]

Change committed as 157072