Use the user's preferred downloads directory for creating the initial download file.

Use the user's preferred downloads directory for creating the initial download file.

BUG=132240
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157022

[asanka, 2012-09-14 01:35:37]

Only does regular downloads for the moment. The plumbing for SavePackage isn't
there yet and will probably be quite hairy.

[Randy Smith (Not in Mondays), 2012-09-14 16:38:16]

http://codereview.chromium.org/10905284/diff/1/content/browser/download/base_...
File content/browser/download/base_file.h (right):

http://codereview.chromium.org/10905284/diff/1/content/browser/download/base_...
content/browser/download/base_file.h:116: FilePath download_directory_;
I'm tempted to suggest that instead of doing this we switch the full_path_ into
"directory_" and "name_", and create the temp file in directory_ if name_ is
null.  They're both ugly, but that seems a little more flexible.  Why should
BaseFile have knowledge of the download_directory_?

http://codereview.chromium.org/10905284/diff/1/content/browser/download/save_...
File content/browser/download/save_file.cc (right):

http://codereview.chromium.org/10905284/diff/1/content/browser/download/save_...
content/browser/download/save_file.cc:20: GetDefaultDownloadDirectory(),
Is this safe to access on the file thread?

[asanka, 2012-09-14 19:11:45]

http://codereview.chromium.org/10905284/diff/1/content/browser/download/base_...
File content/browser/download/base_file.h (right):

http://codereview.chromium.org/10905284/diff/1/content/browser/download/base_...
content/browser/download/base_file.h:116: FilePath download_directory_;
On 2012/09/14 16:38:16, rdsmith wrote:
> I'm tempted to suggest that instead of doing this we switch the full_path_
into
> "directory_" and "name_", and create the temp file in directory_ if name_ is
> null.  They're both ugly, but that seems a little more flexible.  Why should
> BaseFile have knowledge of the download_directory_?

I added a parameter to Initialize() instead and called it default_directory.

http://codereview.chromium.org/10905284/diff/1/content/browser/download/save_...
File content/browser/download/save_file.cc (right):

http://codereview.chromium.org/10905284/diff/1/content/browser/download/save_...
content/browser/download/save_file.cc:20: GetDefaultDownloadDirectory(),
On 2012/09/14 16:38:16, rdsmith wrote:
> Is this safe to access on the file thread?

It's documented as "can be called on any thread."

[Randy Smith (Not in Mondays), 2012-09-14 19:17:51]

LGTM.  Thanks!

[commit-bot: I haz the power, 2012-09-15 01:43:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10905284/16

[commit-bot: I haz the power, 2012-09-15 03:32:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-15 19:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10905284/16

[commit-bot: I haz the power, 2012-09-15 22:21:03]

Change committed as 157022