Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10905250: chromeos: Use EventRouterForwarder to disptch systemPrivate extension events (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

chromeos: Use EventRouterForwarder to disptch systemPrivate extension events BUG=148552 TEST=Boot a Chromebook, type the password for a user, start pressing brightness up/down key randomly, press Enter to login while keeping pressing brightness keys, ensure no crash report is sent during login. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156744

Patch Set 1 #

Patch Set 2 : Use EventRouterForwarder #

Total comments: 3

Patch Set 3 : Remove obsolete comments #

Patch Set 4 : Remove unneeded newlines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/browser/extensions/system/system_api.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/system/system_api.cc View 1 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
Small temporary fix to avoid crbug.com/148878 I would like to submit this instead of http://codereview.chromium.org/10911261/ ...
8 years, 3 months ago (2012-09-13 04:06:58 UTC) #1
hashimoto
New patch set with EventRouterForwarder. Please review.
8 years, 3 months ago (2012-09-13 19:47:54 UTC) #2
Mihai Parparita -not on Chrome
http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h File chrome/browser/extensions/system/system_api.h (right): http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h#newcode39 chrome/browser/extensions/system/system_api.h:39: // |profile| is used to get extensions::EventRouter. |profile| is ...
8 years, 3 months ago (2012-09-13 19:49:52 UTC) #3
satorux1
LGTM with the nit pointed by mihaip fixed. http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h File chrome/browser/extensions/system/system_api.h (right): http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h#newcode39 chrome/browser/extensions/system/system_api.h:39: // ...
8 years, 3 months ago (2012-09-13 19:52:08 UTC) #4
hashimoto
http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h File chrome/browser/extensions/system/system_api.h (right): http://codereview.chromium.org/10905250/diff/4001/chrome/browser/extensions/system/system_api.h#newcode39 chrome/browser/extensions/system/system_api.h:39: // |profile| is used to get extensions::EventRouter. On 2012/09/13 ...
8 years, 3 months ago (2012-09-13 19:52:26 UTC) #5
hashimoto
Mihai, May I have your LGTM for this change as an owner of browser/extensions?
8 years, 3 months ago (2012-09-13 19:54:34 UTC) #6
Mihai Parparita -not on Chrome
LGTM
8 years, 3 months ago (2012-09-13 20:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10905250/11001
8 years, 3 months ago (2012-09-13 20:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10905250/11001
8 years, 3 months ago (2012-09-14 03:58:35 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 04:26:47 UTC) #10 
Change committed as 156744

Powered by Google App Engine
This is Rietveld 408576698