Chromium Code Reviews| Index: chrome/installer/launcher_support/chrome_launcher_support.cc |
| diff --git a/chrome/installer/launcher_support/chrome_launcher_support.cc b/chrome/installer/launcher_support/chrome_launcher_support.cc |
| index c92f771a4735c3a0a141056e05840e2c98d9633a..40834c1fe2ef605327c1b9ede6cb81629bcfe7bf 100644 |
| --- a/chrome/installer/launcher_support/chrome_launcher_support.cc |
| +++ b/chrome/installer/launcher_support/chrome_launcher_support.cc |
| @@ -8,6 +8,7 @@ |
| #include <tchar.h> |
| #include "base/file_path.h" |
| #include "base/file_util.h" |
| +#include "base/logging.h" |
| #ifndef OFFICIAL_BUILD |
| #include "base/path_service.h" |
| #endif |
| @@ -18,12 +19,13 @@ namespace { |
| // TODO(erikwright): These constants are duplicated all over the place. |
| // Consolidate them somehow. |
| -const wchar_t kChromeRegClientStateKey[] = |
| +const wchar_t kChromeBinariesRegClientStateKey[] = |
| L"Software\\Google\\Update\\ClientState\\" |
| - L"{8A69D345-D564-463c-AFF1-A69D9E530F96}"; |
| + L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}"; |
| const wchar_t kUninstallStringField[] = L"UninstallString"; |
| +// Copied from util_constants.cc |
| const wchar_t kChromeExe[] = L"chrome.exe"; |
| #ifndef OFFICIAL_BUILD |
| @@ -56,38 +58,47 @@ FilePath GetAnyChromePath() { |
| return chrome_path; |
| } |
| -FilePath GetChromePathForInstallationLevel(InstallationLevel level) { |
| +FilePath GetSetupExeForInstallationLevel(InstallationLevel level) { |
| using base::win::RegKey; |
| HKEY root_key = (level == USER_LEVEL_INSTALLATION ? |
| HKEY_CURRENT_USER : |
| HKEY_LOCAL_MACHINE); |
| - RegKey reg_key(root_key, kChromeRegClientStateKey, KEY_QUERY_VALUE); |
| - |
| - FilePath chrome_exe_path; |
| - |
| - if (reg_key.Valid()) { |
| - // Now grab the uninstall string from the appropriate ClientState key |
| - // and use that as the base for a path to chrome.exe. |
| + RegKey reg_key; |
| + LOG(INFO) << "Seeking reg: " << kChromeBinariesRegClientStateKey; |
|
erikwright (departed)
2012/09/13 01:13:44
remove log statement.
huangs
2012/09/13 04:40:47
Done.
|
| + if (reg_key.Open(root_key, kChromeBinariesRegClientStateKey, |
| + KEY_QUERY_VALUE) == ERROR_SUCCESS) { |
| + // Grab the UninstallString (actually, uninstall progra)m from |
|
erikwright (departed)
2012/09/13 01:13:44
This comment is confusing, and actually no comment
huangs
2012/09/13 04:40:47
Done.
|
| + // Chrome Binaries, and use that as the base for a path to setup.exe. |
| string16 uninstall; |
| if (reg_key.ReadValue(kUninstallStringField, &uninstall) == ERROR_SUCCESS) { |
| - // The uninstall path contains the path to setup.exe which is two levels |
| - // down from chrome.exe. Move up two levels (plus one to drop the file |
| - // name) and look for chrome.exe from there. |
| - FilePath uninstall_path(uninstall); |
| - chrome_exe_path = |
| - uninstall_path.DirName().DirName().DirName().Append(kChromeExe); |
| - if (!file_util::PathExists(chrome_exe_path)) { |
| - // By way of mild future proofing, look up one to see if there's a |
| - // chrome.exe in the version directory |
| - chrome_exe_path = |
| - uninstall_path.DirName().DirName().Append(kChromeExe); |
| - } |
| + // Trim the command line parameters. |
| + FilePath setup_exe_path(uninstall); |
| + LOG(INFO) << "Seeking file: " << setup_exe_path.value(); |
|
erikwright (departed)
2012/09/13 01:13:44
Remove log statement.
huangs
2012/09/13 04:40:47
Done.
|
| + if (file_util::PathExists(setup_exe_path)) |
| + return setup_exe_path; |
| } |
| } |
| + return FilePath(); |
| +} |
| - if (file_util::PathExists(chrome_exe_path)) |
| - return chrome_exe_path; |
| - |
| +FilePath GetChromePathForInstallationLevel(InstallationLevel level) { |
| + FilePath setup_exe_path(GetSetupExeForInstallationLevel(level)); |
| + if (!setup_exe_path.empty()) { |
| + FilePath chrome_exe_path; |
| + // The uninstall path contains the path to setup.exe which is two levels |
| + // down from chrome.exe. Move up two levels (plus one to drop the file |
| + // name) and look for chrome.exe from there. |
| + chrome_exe_path = |
| + setup_exe_path.DirName().DirName().DirName().Append(kChromeExe); |
| + if (!file_util::PathExists(chrome_exe_path)) { |
| + // By way of mild future proofing, look up one to see if there's a |
| + // chrome.exe in the version directory |
| + chrome_exe_path = |
| + chrome_exe_path.DirName().DirName().Append(kChromeExe); |
| + } |
| + if (file_util::PathExists(chrome_exe_path)) |
| + return chrome_exe_path; |
| + } |
| return FilePath(); |
| } |