Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10905234: Fix for issue 4921: ad the generic type info to a List when we create it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 12240)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -2377,7 +2377,9 @@
new js.PropertyAccess.field(pop(), typeVariable.toString());
js.Expression genericName = new js.LiteralString("'${arguments.head}'");
js.Binary eqTest = new js.Binary('===', field, genericName);
- result = new js.Binary('&&', result, eqTest);
+ js.Prefix nullTest = new js.Prefix('!', field);
kasperl 2012/09/12 12:19:04 Add a comment that explains why it is necessary to
ngeoffray 2012/09/12 12:30:39 Done.
+ result = new js.Binary(
+ '&&', result, new js.Binary('||', eqTest, nullTest));
}
push(result, node);
}

Powered by Google App Engine
This is Rietveld 408576698