Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10905233: Whenever possible use length passed to the List constructor for bounds checks instead of loading it… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address Srdjan's comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index b670dcac5b393378cc8a80706ae6501b562f0e12..23fd108c286ed4d117ba84f708c763a4a80c5765 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -2272,6 +2272,38 @@ void CheckArrayBoundInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
+LocationSummary* CheckBoundInstr::MakeLocationSummary() const {
+ const intptr_t kNumInputs = 2;
+ const intptr_t kNumTemps = 0;
+ LocationSummary* locs =
+ new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+ locs->set_in(0, Location::RequiresRegister());
+ locs->set_in(1, Location::RegisterOrConstant(index()));
+ return locs;
+}
+
+
+void CheckBoundInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ Register length = locs()->in(0).reg();
+
+ Label* deopt = compiler->AddDeoptStub(deopt_id(),
+ kDeoptLoadIndexedFixedArray);
+
+ if (locs()->in(1).IsConstant()) {
+ const Object& constant = locs()->in(1).constant();
+ ASSERT(constant.IsSmi());
+ const int64_t imm =
+ reinterpret_cast<int64_t>(constant.raw());
+ __ cmpq(length, Immediate(imm));
+ __ j(BELOW_EQUAL, deopt);
+ } else {
+ Register index = locs()->in(1).reg();
+ __ cmpq(index, length);
+ __ j(ABOVE_EQUAL, deopt);
+ }
+}
+
+
} // namespace dart
#undef __
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698