Fixed bounds check removal by restricting it to int32 indexes (and reenabled both ABCR and index de…

test/mjsunit/array-bounds-check-removal.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11 matching lines @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc
 
 var a = new Int32Array(1024);
 
+// Test that we do not assert if the accessed index has not an int32 rep.
+{
+        var v = [0, 1, 2, 3, 4, 5, 6, 7,8, 9];

[Toon Verwaest, 2012/09/12 15:51:47]

nit:
The indentation seems to be off.
There's no space before the 8.

+
+        function test(vector, base) {
+                var r = 0;
+                var a1 = base + 1;
+                var a2 = base + 2;
+                var a3 = base + 3;
+                var a4 = base + 4;
+                if (a1 == 2) {
+                        r += vector[a1];
+                        r += vector[a4];
+                        r += vector[a2];
+                        r += vector[a3];
+                } else {
+                        return r;

[Toon Verwaest, 2012/09/12 15:51:47]

nit:
We can just drop the else branch.

+                }
+                return r;
+        }
+
+        test(v,1);
+        test(v,1);
+        test(v,"a");
+        test(v,"a");
+        %OptimizeFunctionOnNextCall(test);
+        test(v,0);
+}
+
 function test_base(base,cond) {
   a[base + 1] = 1;
   a[base + 4] = 2;
   a[base + 3] = 3;
   a[base + 2] = 4;
   a[base + 4] = base + 4;
   if (cond) {
     a[base + 1] = 1;
     a[base + 2] = 2;
     a[base + 2] = 3;
@@ skipping 108 matching lines @@
 short_test(short_a, 50);
 short_test(short_a, 50);
 %OptimizeFunctionOnNextCall(short_test);
 short_a.length = 10;
 short_test(a, 0);
 assertTrue(%GetOptimizationStatus(short_test) != 1);
 
 
 gc();