Issue 10905232: Fixed bounds check removal by restricting it to int32 indexes (and reenabled both ABCR and index de…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905232: Fixed bounds check removal by restricting it to int32 indexes (and reenabled both ABCR and index de… (Closed)

Created:
8 years, 3 months ago by Massi

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed bounds check removal by restricting it to int32 indexes (and reenabled both ABCR and index dehoisting). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12493

Patch Set 1 #

Patch Set 2 : Added test. #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/array-bounds-check-removal.js	View	1	1 chunk	+29 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

DBC: please add a test to ensure coverage.

8 years, 3 months ago (2012-09-12 10:06:52 UTC) #2

Toon Verwaest

8 years, 3 months ago (2012-09-12 15:51:46 UTC) #4

lgtm with nits.

https://chromiumcodereview.appspot.com/10905232/diff/2002/test/mjsunit/array-...
File test/mjsunit/array-bounds-check-removal.js (right):

https://chromiumcodereview.appspot.com/10905232/diff/2002/test/mjsunit/array-...
test/mjsunit/array-bounds-check-removal.js:34: var v = [0, 1, 2, 3, 4, 5, 6,
7,8, 9];
nit:
The indentation seems to be off.
There's no space before the 8.

https://chromiumcodereview.appspot.com/10905232/diff/2002/test/mjsunit/array-...
test/mjsunit/array-bounds-check-removal.js:48: return r;
nit:
We can just drop the else branch.

Expand Messages | Collapse Messages