Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10905231: Enable cc_unittests in component build (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
nduca
CC:
chromium-reviews, enne (OOO), danakj
Visibility:
Public.

Description

Enable cc_unittests in component build BUG=148610 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156410

Patch Set 1 #

Patch Set 2 : all tests pass #

Patch Set 3 : mark WebThreadImplForMessageLoop ctor/dtor as exported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -191 lines) Patch
M cc/CCLayerTreeHostTest.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M cc/CCProxy.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCRendererGL.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCThreadProxy.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCThreadedTest.h View 1 5 chunks +14 lines, -16 lines 0 comments Download
M cc/CCThreadedTest.cpp View 1 6 chunks +71 lines, -150 lines 0 comments Download
M cc/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 3 chunks +7 lines, -3 lines 0 comments Download
M cc/test/CCSchedulerTestCommon.h View 1 chunk +4 lines, -1 line 0 comments Download
M cc/test/run_all_unittests.cc View 1 1 chunk +59 lines, -10 lines 0 comments Download
M webkit/glue/webthread_impl.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
This works for everything except the CCLayerTree* tests, which are all of the interesting threading ...
8 years, 3 months ago (2012-09-12 06:39:37 UTC) #1
jamesr
This patch really highlights how we need to have more of the setup/initialization code inside ...
8 years, 3 months ago (2012-09-12 06:40:29 UTC) #2
jamesr
Tests all pass for me now. Main issue were implementing WebKit::Platform::currentThread() and WebKit::Platform::createThread() correctly and ...
8 years, 3 months ago (2012-09-12 07:16:55 UTC) #3
nduca
nice, lgtm
8 years, 3 months ago (2012-09-12 08:02:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10905231/11003
8 years, 3 months ago (2012-09-12 19:13:12 UTC) #5
commit-bot: I haz the power
Try job failure for 10905231-11003 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 3 months ago (2012-09-12 20:15:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10905231/11003
8 years, 3 months ago (2012-09-12 20:43:51 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 23:05:21 UTC) #8
Change committed as 156410

Powered by Google App Engine
This is Rietveld 408576698