Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5103)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 10905215: Kill DownloadManager::SearchDownloads, DownloadItem::MatchesQuery (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/ui/webui/downloads_dom_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 9befc69dd1e63d4cdf5b239525a12cf2f674b54f..18039dd47604ad9fcaf73144aafe31150c3e8261 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -326,7 +326,7 @@ class SavePageBrowserTest : public InProcessBrowserTest {
DownloadItem::DownloadState state) {
// Make sure the relevant download item made it into the history.
std::vector<DownloadItem*> downloads;
- GetDownloadManager()->SearchDownloads(string16(), &downloads);
+ GetDownloadManager()->GetAllDownloads(&downloads);
ASSERT_EQ(1u, downloads.size());
QueryDownloadHistory();
@@ -396,7 +396,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveHTMLOnlyCancel) {
GURL url = NavigateToMockURL("a");
DownloadManager* manager(GetDownloadManager());
std::vector<DownloadItem*> downloads;
- manager->SearchDownloads(string16(), &downloads);
+ manager->GetAllDownloads(&downloads);
ASSERT_EQ(0u, downloads.size());
FilePath full_file_name, dir;
@@ -435,7 +435,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, DISABLED_SaveHTMLOnlyTabDestroy) {
GURL url = NavigateToMockURL("a");
DownloadManager* manager(GetDownloadManager());
std::vector<DownloadItem*> downloads;
- manager->SearchDownloads(string16(), &downloads);
+ manager->GetAllDownloads(&downloads);
ASSERT_EQ(0u, downloads.size());
FilePath full_file_name, dir;
« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/ui/webui/downloads_dom_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698