Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: dart/lib/compiler/implementation/ssa/builder.dart

Issue 10905211: Clean up operator names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class Interceptors { 5 class Interceptors {
6 Compiler compiler; 6 Compiler compiler;
7 Interceptors(Compiler this.compiler); 7 Interceptors(Compiler this.compiler);
8 8
9 SourceString mapOperatorToMethodName(Operator op) { 9 SourceString mapOperatorToMethodName(Operator op) {
10 String name = op.source.stringValue; 10 String name = op.source.stringValue;
(...skipping 2555 matching lines...) Expand 10 before | Expand all | Expand 10 after
2566 } 2566 }
2567 2567
2568 void handleForeignJsHasEquals(Send node) { 2568 void handleForeignJsHasEquals(Send node) {
2569 List<HInstruction> inputs = <HInstruction>[]; 2569 List<HInstruction> inputs = <HInstruction>[];
2570 if (!node.arguments.tail.isEmpty()) { 2570 if (!node.arguments.tail.isEmpty()) {
2571 compiler.cancel( 2571 compiler.cancel(
2572 'More than one expression in JS_HAS_EQUALS()', node: node); 2572 'More than one expression in JS_HAS_EQUALS()', node: node);
2573 } 2573 }
2574 addGenericSendArgumentsToList(node.arguments, inputs); 2574 addGenericSendArgumentsToList(node.arguments, inputs);
2575 String name = backend.namer.publicInstanceMethodNameByArity( 2575 String name = backend.namer.publicInstanceMethodNameByArity(
2576 Elements.OPERATOR_EQUALS, 1); 2576 const SourceString('=='), 1);
floitsch 2012/10/17 12:13:47 No need to change, but ok.
ahe 2012/11/12 13:22:09 I removed the field, so I do need to change it.
2577 push(new HForeign(new DartString.literal('!!#.$name'), 2577 push(new HForeign(new DartString.literal("!!#['$name']"),
2578 const LiteralDartString('bool'), 2578 const LiteralDartString('bool'),
2579 inputs)); 2579 inputs));
2580 } 2580 }
2581 2581
2582 void handleForeignJsCurrentIsolate(Send node) { 2582 void handleForeignJsCurrentIsolate(Send node) {
2583 if (!node.arguments.isEmpty()) { 2583 if (!node.arguments.isEmpty()) {
2584 compiler.cancel( 2584 compiler.cancel(
2585 'Too many arguments to JS_CURRENT_ISOLATE', node: node); 2585 'Too many arguments to JS_CURRENT_ISOLATE', node: node);
2586 } 2586 }
2587 2587
(...skipping 1894 matching lines...) Expand 10 before | Expand all | Expand 10 after
4482 new HSubGraphBlockInformation(elseBranch.graph)); 4482 new HSubGraphBlockInformation(elseBranch.graph));
4483 4483
4484 HBasicBlock conditionStartBlock = conditionBranch.block; 4484 HBasicBlock conditionStartBlock = conditionBranch.block;
4485 conditionStartBlock.setBlockFlow(info, joinBlock); 4485 conditionStartBlock.setBlockFlow(info, joinBlock);
4486 SubGraph conditionGraph = conditionBranch.graph; 4486 SubGraph conditionGraph = conditionBranch.graph;
4487 HIf branch = conditionGraph.end.last; 4487 HIf branch = conditionGraph.end.last;
4488 assert(branch is HIf); 4488 assert(branch is HIf);
4489 branch.blockInformation = conditionStartBlock.blockFlow; 4489 branch.blockInformation = conditionStartBlock.blockFlow;
4490 } 4490 }
4491 } 4491 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698