Clean up operator names.

dart/lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('dart:uri');
 
 // TODO(ahe): Rename prefix to 'api' when VM bug is fixed.
 #import('../../compiler.dart', prefix: 'api_e');
@@ skipping 1738 matching lines @@
     return isLocal(element);
   }
 
   static SourceString constructConstructorName(SourceString receiver,
                                                SourceString selector) {
     String r = receiver.slowToString();
     String s = selector.slowToString();
     return new SourceString('$r\$$s');
   }
 
-  static const SourceString OPERATOR_EQUALS =
-      const SourceString(r'operator$eq');
-
-  static SourceString constructOperatorName(SourceString selector,
-                                            bool isUnary) {
-    String str = selector.stringValue;
-    if (str === '==' || str === '!=') return OPERATOR_EQUALS;
-
-    if (str === '~') {
-      str = 'not';
-    } else if (str === '-' && isUnary) {
-      // TODO(ahe): Return something like 'unary -'.
-      return const SourceString('negate');
-    } else if (str === '[]') {
-      str = 'index';
-    } else if (str === '[]=') {
-      str = 'indexSet';
-    } else if (str === '*' || str === '*=') {
-      str = 'mul';
-    } else if (str === '/' || str === '/=') {
-      str = 'div';
-    } else if (str === '%' || str === '%=') {
-      str = 'mod';
-    } else if (str === '~/' || str === '~/=') {
-      str = 'tdiv';
-    } else if (str === '+' || str === '+=') {
-      str = 'add';
-    } else if (str === '-' || str === '-=') {
-      str = 'sub';
-    } else if (str === '<<' || str === '<<=') {
-      str = 'shl';
-    } else if (str === '>>' || str === '>>=') {
-      str = 'shr';
-    } else if (str === '>=') {
-      str = 'ge';
-    } else if (str === '>') {
-      str = 'gt';
-    } else if (str === '<=') {
-      str = 'le';
-    } else if (str === '<') {
-      str = 'lt';
-    } else if (str === '&' || str === '&=') {
-      str = 'and';
-    } else if (str === '^' || str === '^=') {
-      str = 'xor';
-    } else if (str === '|' || str === '|=') {
-      str = 'or';
-    } else if (selector == const SourceString('negate')) {
-      // TODO(ahe): Remove this case: Legacy support for pre-0.11 spec.
-      return selector;
-    } else if (str === '?') {
-      return selector;
+  static SourceString constructOperatorName(SourceString op, bool isUnary) {
+    String value = op.stringValue;
+    if ((value === '==') ||
+        (value === '~') ||
+        (value === '[]') ||
+        (value === '[]=') ||
+        (value === '*') ||
+        (value === '/') ||
+        (value === '%') ||
+        (value === '~/') ||
+        (value === '+') ||
+        (value === '<<') ||
+        (value === '>>>') ||
+        (value === '>>') ||
+        (value === '>=') ||
+        (value === '>') ||
+        (value === '<=') ||
+        (value === '<') ||
+        (value === '&') ||
+        (value === '^') ||
+        (value === '|')) {
+      return op;

[erikcorry, 2012/10/17 12:46:39]

Having property names that are not valid identifiers will cause V8 to transition
the object to dictionary mode very eagerly.  I don't think we want to do that
because it is much slower.

[ahe, 2012/11/12 13:22:09]

Done.

+    } else if (value === '-') {
+      return isUnary ? const SourceString('unary -') : op;
     } else {
-      throw new Exception('Unhandled selector: ${selector.slowToString()}');
+      throw 'Unhandled operator: ${op.slowToString()}';
     }
-    return new SourceString('operator\$$str');
   }
 
   static SourceString mapToUserOperator(SourceString op) {
     String value = op.stringValue;
 
     if (value === '!=') return const SourceString('==');
     if (value === '*=') return const SourceString('*');
     if (value === '/=') return const SourceString('/');
     if (value === '%=') return const SourceString('%');
     if (value === '~/=') return const SourceString('~/');
@@ skipping 138 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }