Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: dart/utils/compiler/buildbot.py

Issue 10905208: Add --step_name option to test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review commens Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/utils/compiler/buildbot.py
diff --git a/dart/utils/compiler/buildbot.py b/dart/utils/compiler/buildbot.py
index 6da39b1e23e24ecc63f3a246ece894744dfc2458..1b9a1d2a48431edc7d03df1012a9f82d94cb4090 100644
--- a/dart/utils/compiler/buildbot.py
+++ b/dart/utils/compiler/buildbot.py
@@ -105,11 +105,12 @@ def TestStepName(name, flags):
# Filter out flags with '=' as this breaks the /stats feature of the
# build bot.
flags = [x for x in flags if not '=' in x]
- return '%s tests %s' % (name, ' '.join(flags))
+ return ('%s tests %s' % (name, ' '.join(flags))).strip()
def TestStep(name, mode, system, compiler, runtime, targets, flags):
- print '@@@BUILD_STEP %s@@@' % TestStepName(name, flags)
+ step_name = TestStepName(name, flags)
+ print '@@@BUILD_STEP %s@@@' % step_name
sys.stdout.flush()
if NeedsXterm(compiler, runtime) and system == 'linux':
cmd = ['xvfb-run', '-a']
@@ -120,6 +121,7 @@ def TestStep(name, mode, system, compiler, runtime, targets, flags):
cmd.extend([sys.executable,
os.path.join(os.curdir, 'tools', 'test.py'),
+ '--step_name=' + step_name,
'--mode=' + mode,
'--compiler=' + compiler,
'--runtime=' + runtime,
« no previous file with comments | « dart/tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698