Add --step_name option to test.dart.

dart/utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
@@ skipping 91 matching lines @@
 
 
 def TestStepName(name, flags):
   # Filter out flags with '=' as this breaks the /stats feature of the
   # build bot.
   flags = [x for x in flags if not '=' in x]
   return '%s tests %s' % (name, ' '.join(flags))
 
 
 def TestStep(name, mode, system, compiler, runtime, targets, flags):
-  print '@@@BUILD_STEP %s@@@' % TestStepName(name, flags)
+  step_name = TestStepName(name, flags)
   sys.stdout.flush()
   if NeedsXterm(compiler, runtime) and system == 'linux':
     cmd = ['xvfb-run', '-a']
   else:
     cmd = []
 
   user_test = os.environ.get('USER_TEST', 'no')
 

[ricow1, 2012/09/11 08:14:38]

Why don't we print the @@@BUILD_STEP $step_name@@@ here instead of in the
test.dart script?

   cmd.extend([sys.executable,
               os.path.join(os.curdir, 'tools', 'test.py'),
+              '--step_name=' + step_name,
               '--mode=' + mode,
               '--compiler=' + compiler,
               '--runtime=' + runtime,
               '--time',
               '--use-sdk',
               '--report'])
 
   if user_test == 'yes':
     cmd.append('--progress=color')
   else:
@@ skipping 221 matching lines @@
       and runtime != 'safari'):
     status = TestCompiler(runtime, mode, system, option,
                           test_flags + ['--checked'], is_buildbot)
 
   if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())